[chore] 코스 상세 하단 버튼 크기 조정 #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
reviewed
Sep 11, 2024
| @@ -38,7 +41,7 @@ fun CourseDetailBottomBar( | |||
| onClick = onLikeButtonClicked, | |||
| cornerRadius = 14.dp, | |||
| paddingHorizontal = 23.dp, | |||
| paddingVertical = 18.dp | |||
| paddingVertical = 16.5.dp | |||
There was a problem hiding this comment.
이거 이렇게 패딩 값을 조절하는 게 아니라 기기에서 설정해놓은 폰트 사이즈에 따라 내 일정에 추가하기 버튼 사이즈가 커지거나 작아지면 그거에 맞춰서 좋아요 버튼 크기를 조절해달라는 말인데!
혹시 이거 확인 하셨을까요????
jihyunniiii
approved these changes
Sep 13, 2024
| @@ -22,13 +32,16 @@ fun CourseDetailBottomBar( | |||
| onLikeButtonClicked: () -> Unit, | |||
| onEnrollButtonClicked: () -> Unit | |||
| ) { | |||
| var buttonHeight by remember { mutableStateOf(0.dp) } // 버튼 크기를 저장하는 상태 변수 | |||
There was a problem hiding this comment.
주석 좀 지워주겠서??????????????????/
Comment on lines
41
to
54
| paddingVertical = 18.dp | ||
| paddingVertical = 16.5.dp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
폰트 커졌을 때 기기대응!
Uncompleted Tasks 😅
To Reviewers 📢
똑같아 보이나...? 피그마에 나온 값이 좀 이상한데 한번 더 같이 체크해봐요!