Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] 코스 상세 하단 버튼 크기 조정 #250

Merged
merged 5 commits into from
Sep 13, 2024
Merged

[chore] 코스 상세 하단 버튼 크기 조정 #250

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e41f8ec
[chore] #249 change button vertical padding value
t1nm1ksun Sep 11, 2024
f15442a
[chore] #249 ktlint Format
t1nm1ksun Sep 11, 2024
ca4516f
[chore] #249 하단 버튼 사이즈 기기대응
t1nm1ksun Sep 13, 2024
3a974e5
[chore] #249 주석 제거
t1nm1ksun Sep 13, 2024
9aa01b2
[chore] #249 하단 버튼 패딩값 제거
t1nm1ksun Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ...in/java/org/sopt/dateroad/presentation/ui/coursedetail/component/CourseDetailBottomBar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
package org.sopt.dateroad.presentation.ui.coursedetail.component

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import org.sopt.dateroad.R
import org.sopt.dateroad.presentation.ui.component.button.DateRoadBasicButton
Expand Down Expand Up @@ -38,7 +41,7 @@ fun CourseDetailBottomBar(
onClick = onLikeButtonClicked,
cornerRadius = 14.dp,
paddingHorizontal = 23.dp,
paddingVertical = 18.dp
paddingVertical = 16.5.dp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 이렇게 패딩 값을 조절하는 게 아니라 기기에서 설정해놓은 폰트 사이즈에 따라 내 일정에 추가하기 버튼 사이즈가 커지거나 작아지면 그거에 맞춰서 좋아요 버튼 크기를 조절해달라는 말인데!
혹시 이거 확인 하셨을까요????

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 다시 18.dp로 돌려주세용

)
Spacer(modifier = Modifier.width(12.dp))
DateRoadBasicButton(
Expand All @@ -48,3 +51,16 @@ fun CourseDetailBottomBar(
)
}
}

@Preview
@Composable
fun ButtonPreview(modifier: Modifier = Modifier) {
Box(modifier = Modifier) {
CourseDetailBottomBar(
modifier = Modifier.align(Alignment.BottomCenter),
isUserLiked = true,
onLikeButtonClicked = { },
onEnrollButtonClicked = { }
)
}
}
Loading