Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ⬆️ upgrade all dependencies #53

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

alphainfinitus
Copy link
Contributor

@alphainfinitus alphainfinitus commented Feb 14, 2024

Upgrades node version to LTS and all dependencies to latest using yarn.
Fixes build errors.

Upgrades all dependencies to latest using yarn
Copy link
Member

@hoonsubin hoonsubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR #54 should update the node version to the latest stable for the workflow.

Please update the PR (note that there is an issue with the Jest ESM config, that should also be updated)

@alphainfinitus
Copy link
Contributor Author

Hi @hoonsubin, the PR has been updated. Please give it a look. Thanks!

@alphainfinitus
Copy link
Contributor Author

alphainfinitus commented Feb 14, 2024

@hoonsubin , I've fixed the CI build. The unit test now runs successfully.
The unit test will fail due to semantic errors in the test, i believe.

@hoonsubin
Copy link
Member

@hoonsubin , I've fixed the CI build. The unit test now runs successfully. The unit test will fail due to logical errors in the test due to semantic errors in the test, i believe.

I see! I'll give it one more check and get back to you

Copy link
Member

@hoonsubin hoonsubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoonsubin hoonsubin merged commit 93f1a49 into TeamSTEP:master Feb 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants