Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed path of animation library if external_save_path is empty. #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vibrant-reindeer
Copy link

Previously a file characters/player/player.pxo would result in an animation library file characters/playerplayer-animations.tres

@Technohacker
Copy link
Owner

Thanks for the PR! I can't quite test it out on my end atm so it may take a while for me to merge it, but in the meantime could you describe the problem in a little more detail?

@vibrant-reindeer
Copy link
Author

Here's a full project example. The file name is characters/player/player.pxo.

  • The generated animation player file name is characters/playerplayer-animations.tres when (presumably) it should be characters/player/player-animations.tres. In other words: The generated path is missing a path separator.

image

Project with the problem:

godot_pixelorama_importer_bug11.zip

(I have to say though, I have moved on to https://github.com/nklbdev/godot-4-importality . Not to dismiss the hard work that went into godot_pixelorama_importer, but the other plugin just works for me and doesn't have the show-stopper bug #13 .

@Technohacker
Copy link
Owner

(I have to say though, I have moved on to https://github.com/nklbdev/godot-4-importality . Not to dismiss the hard work that went into godot_pixelorama_importer, but the other plugin just works for me and doesn't have the show-stopper bug #13.

Can't blame you tbf, it's been a while since I've been in the gamedev space so I've not been able to keep it up-to-date 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants