Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refs #8][Godot 3] Add AnimationPlayer import #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[refs #8][Godot 3] Add AnimationPlayer import #9

wants to merge 3 commits into from

Conversation

Kerberross
Copy link
Contributor

Add the animation player import to godot 3.

The import option contains:

  • scale for the sprite
  • external save for animation
  • external save path for the animation

It also:

  • use the fps stored in the pxo file for animation instead of an import parameter
  • add default project settings for import parameter and default import type

More details in #8

Technohacker
Technohacker reviewed Jan 11, 2023
View reviewed changes
Copy link
Owner

@Technohacker Technohacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a few comments from my side :)

addons/godot_pixelorama_importer/animation_player_import.gd Outdated
{"name": "Sprite2D", "default_value": false, "usage": PROPERTY_USAGE_GROUP},
{"name": "scale", "default_value": default_scale},
{"name": "Animation", "default_value": false, "usage": PROPERTY_USAGE_GROUP},
# 65536 = PROPERTY_USAGE_UPDATE_ALL_IF_MODIFIED, but not exported in GDscript.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this fix the reload issue for the SpriteFrames importer as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly no, it only refreshes the import panel, and call the get_option_visibility method

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh okay

@Kerberross
Copy link
Contributor Author

One things I forgot to mention, the open Pixelorama doesn't work with this import, the double click is the default Godot behavior (a dialog asking to create an inherited scene)

@Kerberross Kerberross mentioned this pull request Jan 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technohacker Technohacker Technohacker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kerberross @Technohacker