-
Notifications
You must be signed in to change notification settings - Fork 307
fix(Icon): supplementary image width and height #2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 203 kB ℹ️ View Unchanged
|
jarmywang
approved these changes
May 27, 2024
LGTM,TY!😀 |
anlyyao
added a commit
that referenced
this pull request
May 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
fix #2797
问题背景:
需求:像1.3.x版本一样。支持直接给icon传图片链接,也能正常显示
问题分析:icon组件的size属性默认为inherit本身是比较合适的,1.4.0版中icon组件为适配skyline将1em变更为100%,由一个具体宽高值变成需要依赖父容器宽高,带来的问题就是图片资源必须要指定宽高(通过传入size属性、覆盖组件样式等方式处理)。
最终方案:和设计师讨论之后,决定将图片资源的默认宽高取 40rpx, 继续保留icon组件的size属性默认值为inherit。
💡 需求背景和解决方案
📝 更新日志
fix(Icon): 补充图片资源宽高
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单