Skip to content

fix(sqlserver): 优化停止sqlserver例行备份的逻辑 #10064 #10071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

fix(sqlserver): 优化停止sqlserver例行备份的逻辑 #10064 #10071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions dbm-ui/backend/flow/utils/sqlserver/sqlserver_db_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,25 +289,33 @@ def exec_instance_backup_jobs(cluster_id, backup_jobs_type: SqlserverBackupJobEx
操作实例的例行备份作业
"""
cluster = Cluster.objects.get(id=cluster_id)
# 获取当前cluster的主节点,每个集群有且只有一个master/orphan 实例
master_instance = cluster.storageinstance_set.get(
instance_role__in=[InstanceRole.ORPHAN, InstanceRole.BACKEND_MASTER]
# 获取当前cluster所有主备节点信息
instances = cluster.storageinstance_set.filter(
instance_role__in=[InstanceRole.ORPHAN, InstanceRole.BACKEND_MASTER, InstanceRole.BACKEND_SLAVE],
is_stand_by=True,
)

ret = DRSApi.sqlserver_rpc(
{
"bk_cloud_id": cluster.bk_cloud_id,
"addresses": [master_instance.ip_port],
"cmds": [
f"exec msdb.dbo.sp_update_job @job_name='TC_BACKUP_FULL',@enabled={backup_jobs_type}",
f"exec msdb.dbo.sp_update_job @job_name='TC_BACKUP_LOG',@enabled={backup_jobs_type}",
],
"force": False,
}
)
if ret[0]["error_msg"]:
raise Exception(f"[{master_instance.ip_port}] exec backup-jobs failed: {ret[0]['error_msg']}")

for instance in instances:
ret = DRSApi.sqlserver_rpc(
{
"bk_cloud_id": cluster.bk_cloud_id,
"addresses": [instance.ip_port],
"cmds": [
f"exec msdb.dbo.sp_update_job @job_name='TC_BACKUP_FULL',@enabled={backup_jobs_type}",
f"exec msdb.dbo.sp_update_job @job_name='TC_BACKUP_LOG',@enabled={backup_jobs_type}",
],
"force": False,
}
)
if ret[0]["error_msg"]:
if instance.status == InstanceStatus.UNAVAILABLE:
logger.warning(
f"[{instance.ip_port}] exec backup-jobs failed: {ret[0]['error_msg']},"
f"but status is unavailable ,skip"
)
else:
raise Exception(f"[{instance.ip_port}] exec backup-jobs failed: {ret[0]['error_msg']}")
logger.info(f"[{instance.ip_port}] exec backup-jobs successfully")
return True


Expand Down