Code cleanup and added the command /wqt debug

.vscode/bookmarks.json

@@ -3,32 +3,32 @@
 		"path": "$ROOTPATH$\\WorldQuestTracker_Core.lua",
 		"bookmarks": [
 			{
-				"line": 953,
+				"line": 942,
 				"column": 30,
 				"label": ""
 			},
 			{
-				"line": 1982,
+				"line": 1971,
 				"column": 23,
 				"label": ""
 			},
 			{
-				"line": 2100,
+				"line": 2089,
 				"column": 0,
 				"label": ""
 			},
 			{
-				"line": 2213,
+				"line": 2202,
 				"column": 96,
 				"label": ""
 			},
 			{
-				"line": 2302,
+				"line": 2291,
 				"column": 25,
 				"label": ""
 			},
 			{
-				"line": 2633,
+				"line": 2622,
 				"column": 4,
 				"label": ""
 			}
@@ -98,22 +98,22 @@
 		"path": "$ROOTPATH$\\WorldQuestTracker_ZoneMap.lua",
 		"bookmarks": [
 			{
-				"line": 443,
+				"line": 434,
 				"column": 15,
 				"label": ""
 			},
 			{
-				"line": 1128,
+				"line": 1115,
 				"column": 59,
 				"label": ""
 			},
 			{
-				"line": 1174,
+				"line": 1161,
 				"column": 4,
 				"label": ""
 			},
 			{
-				"line": 1492,
+				"line": 1479,
 				"column": 97,
 				"label": ""
 			}
@@ -123,17 +123,17 @@
 		"path": "$ROOTPATH$\\WorldQuestTracker_MapAPI.lua",
 		"bookmarks": [
 			{
-				"line": 262,
+				"line": 268,
 				"column": 132,
 				"label": ""
 			},
 			{
-				"line": 738,
+				"line": 747,
 				"column": 0,
 				"label": ""
 			},
 			{
-				"line": 796,
+				"line": 805,
 				"column": 4,
 				"label": ""
 			}
@@ -143,22 +143,22 @@
 		"path": "$ROOTPATH$\\WorldQuestTracker_WorldMap.lua",
 		"bookmarks": [
 			{
-				"line": 358,
+				"line": 347,
 				"column": 41,
 				"label": ""
 			},
 			{
-				"line": 660,
+				"line": 649,
 				"column": 31,
 				"label": ""
 			},
 			{
-				"line": 886,
+				"line": 883,
 				"column": 18,
 				"label": ""
 			},
 			{
-				"line": 1058,
+				"line": 1055,
 				"column": 0,
 				"label": ""
 			}
@@ -167,6 +167,11 @@
 	{
 		"path": "f:\\World of Warcraft\\_retail_\\Interface\\AddOns\\WorldQuestsList\\WorldQuestsList.lua",
 		"bookmarks": [
+			{
+				"line": 4858,
+				"column": 19,
+				"label": ""
+			},
 			{
 				"line": 7920,
 				"column": 2,

WorldQuestTracker.lua

@@ -36,33 +36,11 @@ local WorldQuestTracker = WorldQuestTrackerAddon
 local ff = WorldQuestTrackerFinderFrame
 local rf = WorldQuestTrackerRareFrame
 
--- 219978
--- /run SetSuperTrackedQuestID(44033);
--- TaskPOI_OnClick
-
-
-local GameCooltip = GameCooltip2
---local Saturate = Saturate
-local floor = floor
---local ceil = ceil
---local ipairs = ipairs
-local GetItemInfo = GetItemInfo
-local GetCurrentMapZone = GetCurrentMapZone
-local GetQuestsForPlayerByMapID = C_TaskQuest.GetQuestsForPlayerByMapID
 local HaveQuestData = HaveQuestData
-local QuestMapFrame_IsQuestWorldQuest = QuestMapFrame_IsQuestWorldQuest or QuestUtils_IsQuestWorldQuest
-local GetNumQuestLogRewardCurrencies = GetNumQuestLogRewardCurrencies
-local GetQuestLogRewardInfo = GetQuestLogRewardInfo
-local GetQuestLogRewardCurrencyInfo = GetQuestLogRewardCurrencyInfo
-local GetQuestLogRewardMoney = GetQuestLogRewardMoney
-local GetNumQuestLogRewards = GetNumQuestLogRewards
+local isWorldQuest = QuestUtils_IsQuestWorldQuest
 local GetQuestInfoByQuestID = C_TaskQuest.GetQuestInfoByQuestID
 local GetQuestTimeLeftMinutes = C_TaskQuest.GetQuestTimeLeftMinutes
 
-local MapRangeClamped = DF.MapRangeClamped
-local FindLookAtRotation = DF.FindLookAtRotation
-local GetDistance_Point = DF.GetDistance_Point
-
 local _
 
 WorldQuestTracker.QuestTrackList = {} --place holder until OnInit is triggered
@@ -405,9 +383,9 @@ function WorldQuestTracker:OnInit()
 
 		--> Court of Farondis 42420
 		--> The Dreamweavers 42170
-		--print ("world quest:", questID, QuestMapFrame_IsQuestWorldQuest (questID), XP, gold)
+		--print ("world quest:", questID, isWorldQuest(questID), XP, gold)
 
-		if (QuestMapFrame_IsQuestWorldQuest (questID)) then
+		if (isWorldQuest(questID)) then
 			--print (event, questID, XP, gold)
 			--QUEST_TURNED_IN 44300 0 772000
 			-- QINFO: 0 nil nil Petrified Axe Haft true 370
@@ -417,7 +395,7 @@ function WorldQuestTracker:OnInit()
 
 			FlashClientIcon()
 
-			if (QuestMapFrame_IsQuestWorldQuest (questID)) then --wait, is this inception?
+			if (isWorldQuest(questID)) then --wait, is this inception?
 				local title, factionID, tagID, tagName, worldQuestType, rarity, isElite, tradeskillLineIndex, tagID, tagName, worldQuestType, rarity, isElite, tradeskillLineIndex, allowDisplayPastCritical, gold, goldFormated, rewardName, rewardTexture, numRewardItems, itemName, itemTexture, itemLevel, quantity, quality, isUsable, itemID, isArtifact, artifactPower, isStackable, stackAmount = WorldQuestTracker.GetOrLoadQuestData (questID)
 
 				--print (title, questType, texture, factionID, tagID, tagName, worldQuestType, rarity, isElite, tradeskillLineIndex)
@@ -576,7 +554,7 @@ function WorldQuestTracker:OnInit()
 
 	function WorldQuestTracker:QUEST_LOOT_RECEIVED (event, questID, item, amount, ...)
 		--print ("LOOT", questID, item, amount, ...)
-		if (QuestMapFrame_IsQuestWorldQuest (questID)) then
+		if (isWorldQuest(questID)) then
 		--	local title, questType, texture, factionID, tagID, tagName, worldQuestType, rarity, isElite, tradeskillLineIndex, selected, isSpellTarget, timeLeft, isCriteria, gold, goldFormated, rewardName, rewardTexture, numRewardItems, itemName, itemTexture, itemLevel, quantity, quality, isUsable, itemID, isArtifact, artifactPower, isStackable = WorldQuestTracker:GetQuestFullInfo (questID)
 		--	print ("QINFO:", goldFormated, rewardName, numRewardItems, itemName, isArtifact, artifactPower)
 		end
@@ -635,13 +613,19 @@ end
 	--pega os dados da quest
 	function WorldQuestTracker.GetQuest_Info(questID)
 		if (not HaveQuestData(questID)) then
+			if (WorldQuestTracker.__debug) then
+				WorldQuestTracker:Msg("no HaveQuestData(1) for quest", questID)
+			end
 			return
 		end
 
 		local title, factionID = GetQuestInfoByQuestID(questID)
 
 		local tagInfo = C_QuestLog.GetQuestTagInfo(questID)
 		if (not tagInfo) then
+			if (WorldQuestTracker.__debug) then
+				WorldQuestTracker:Msg("no tagInfo(3) for quest", questID)
+			end
 			return
 		end
 
@@ -650,12 +634,11 @@ end
 		local worldQuestType = tagInfo.worldQuestType
 		local rarity = tagInfo.quality
 		local isElite = tagInfo.isElite
-		--local quality = tagInfo.quality
 
 		return title, factionID, tagID, tagName, worldQuestType, rarity, isElite
 	end
 
-	--pega o icone para as quest que dao goild
+	--pega o icone para as quest que dao gold
 	local goldCoords = {0, 1, 0, 1}
 	function WorldQuestTracker.GetGoldIcon()
 		return [[Interface\AddOns\WorldQuestTracker\media\icon_gold]], goldCoords
@@ -967,8 +950,6 @@ hooksecurefunc ("QuestMapFrame_Close", function()
 	WorldQuestTracker.NeedUpdateLoadingIconAnchor()
 end)
 
-
---C_Timer.NewTicker (5, function()WorldQuestTracker.PlayLoadingAnimation()end)
 function WorldQuestTracker.CreateLoadingIcon()
 	local f = CreateFrame ("frame", nil, WorldMapFrame, "BackdropTemplate")
 	f:SetSize (48, 48)
@@ -1064,7 +1045,28 @@ SLASH_WQTRACKER2 = "/worldquesttracker"
 
 function SlashCmdList.WQTRACKER (msg, editbox)
 
-	if (msg == "statusbar") then
+	if (msg == "reinstall") then
+		local b = CreateFrame("button", "WQTResetConfigButton", UIParent, "OptionsButtonTemplate")
+		tinsert(UISpecialFrames, "WQTResetConfigButton")
+
+		b:SetSize (250, 40)
+		b:SetText ("REINSTALL")
+		b:SetScript ("OnClick", function() 
+			WQTrackerDB = {}
+			WQTrackerDBChr = {}
+			ReloadUI()
+		end)
+		b:SetPoint ("center", UIParent, "center", 0, 0)
+
+	elseif (msg == "debug") then
+		WorldQuestTracker.__debug = not WorldQuestTracker.__debug
+		if (WorldQuestTracker.__debug) then
+			WorldQuestTracker:Msg("debug is now enabled.")
+		else
+			WorldQuestTracker:Msg("debug is disabled.")
+		end
+
+	elseif (msg == "statusbar") then
 		WorldQuestTracker.db.profile.bar_visible = true
 		WorldQuestTracker.RefreshStatusBarVisibility()
 		return
@@ -1173,7 +1175,8 @@ function SlashCmdList.WQTRACKER (msg, editbox)
 
 		end
 
-
+	else
+		WorldQuestTracker:Msg("version:", WQT_VERSION)
 
 	end
 end

WorldQuestTracker_Core.lua

@@ -33,18 +33,7 @@ WorldQuestTracker.WorldSummary = CreateFrame ("frame", "WorldQuestTrackerWorldSu
 local DEV_VERSION_STR = DF:CreateLabel (worldFramePOIs, "")
 
 local _
-local QuestMapFrame_IsQuestWorldQuest = QuestMapFrame_IsQuestWorldQuest or QuestUtils_IsQuestWorldQuest
-local GetNumQuestLogRewardCurrencies = GetNumQuestLogRewardCurrencies
-local GetQuestLogRewardInfo = GetQuestLogRewardInfo
-local GetQuestLogRewardCurrencyInfo = GetQuestLogRewardCurrencyInfo
-local GetQuestLogRewardMoney = GetQuestLogRewardMoney
-local GetNumQuestLogRewards = GetNumQuestLogRewards
-local GetQuestInfoByQuestID = C_TaskQuest.GetQuestInfoByQuestID
-
-local MapRangeClamped = DF.MapRangeClamped
-local FindLookAtRotation = DF.FindLookAtRotation
-local GetDistance_Point = DF.GetDistance_Point
-
+local isWorldQuest = QuestUtils_IsQuestWorldQuest
 local GameCooltip = GameCooltip2
 
 local LibWindow = LibStub ("LibWindow-1.1")
@@ -1289,7 +1278,7 @@ WorldQuestTracker.OnToggleWorldMap = function (self)
 						else
 							--desligou o tracker do tomtom
 							for questID, t in pairs (WorldQuestTracker.TomTomUIDs) do
-								if (type (questID) == "number" and QuestMapFrame_IsQuestWorldQuest (questID)) then
+								if (type (questID) == "number" and isWorldQuest(questID)) then
 									--procura o bot�o da quest
 									for _, widget in ipairs (WorldQuestTracker.WorldMapWidgets) do
 										if (widget.questID == questID) then

WorldQuestTracker_FrameAPI.lua

@@ -22,18 +22,8 @@ end
 local ff = WorldQuestTrackerFinderFrame
 
 local _
-local QuestMapFrame_IsQuestWorldQuest = QuestMapFrame_IsQuestWorldQuest or QuestUtils_IsQuestWorldQuest
-local GetNumQuestLogRewardCurrencies = GetNumQuestLogRewardCurrencies
-local GetQuestLogRewardInfo = GetQuestLogRewardInfo
-local GetQuestLogRewardCurrencyInfo = GetQuestLogRewardCurrencyInfo
-local GetQuestLogRewardMoney = GetQuestLogRewardMoney
-local GetNumQuestLogRewards = GetNumQuestLogRewards
 local GetQuestInfoByQuestID = C_TaskQuest.GetQuestInfoByQuestID
 
-local MapRangeClamped = DF.MapRangeClamped
-local FindLookAtRotation = DF.FindLookAtRotation
-local GetDistance_Point = DF.GetDistance_Point
-
 --debug: print to the chat all quests being tracked
 function WorldQuestTracker.DumpTrackingList()
 	local t = WorldQuestTracker.table.dump (WorldQuestTracker.QuestTrackList)

WorldQuestTracker_GroupFinder.lua

@@ -32,7 +32,7 @@ local GameCooltip = GameCooltip2
 
 local _
 local C_TaskQuest = _G.C_TaskQuest
-local QuestMapFrame_IsQuestWorldQuest = _G.QuestMapFrame_IsQuestWorldQuest or _G.QuestUtils_IsQuestWorldQuest
+local isWorldQuest = QuestUtils_IsQuestWorldQuest
 local GetNumQuestLogRewardCurrencies = _G.GetNumQuestLogRewardCurrencies
 local GetQuestLogRewardInfo = _G.GetQuestLogRewardInfo
 local GetQuestLogRewardCurrencyInfo = _G.GetQuestLogRewardCurrencyInfo
@@ -1141,13 +1141,16 @@ ff:SetScript ("OnEvent", function (self, event, questID, arg2, arg3)
 
 			local tagInfo = C_QuestLog.GetQuestTagInfo(questID)
 			if (not tagInfo) then
+				if (WorldQuestTracker.__debug) then
+					WorldQuestTracker:Msg("no tagInfo(1) for quest", questID)
+				end
 				return
 			end
 			local tagID = tagInfo.tagID
 			local rarity = tagInfo.rarity or 1
 			local isElite = tagInfo.isElite
 
-			local isWorldQuest = QuestMapFrame_IsQuestWorldQuest(questID)
+			local isWorldQuest = isWorldQuest(questID)
 
 			if ((isWorldQuest and isInArea) or allAssaultQuests[questID] or tagID == 112 or (isElite and rarity == LE_WORLD_QUEST_QUALITY_EPIC)) then
 				--FlashClientIcon()
@@ -1168,6 +1171,10 @@ ff:SetScript ("OnEvent", function (self, event, questID, arg2, arg3)
 				ff.CurrentWorldQuest = questID
 				ff:PlayerEnteredWorldQuestZone (questID)
 			end
+		else
+			if (WorldQuestTracker.__debug and not HaveQuestData(questID)) then
+				WorldQuestTracker:Msg("no HaveQuestData(2) for quest", questID)
+			end
 		end 
 
 	elseif (event == "ZONE_CHANGED_NEW_AREA") then
@@ -1188,7 +1195,7 @@ ff:SetScript ("OnEvent", function (self, event, questID, arg2, arg3)
 
 
 	elseif (event == "QUEST_TURNED_IN") then
-		local isWorldQuest = QuestMapFrame_IsQuestWorldQuest (questID)
+		local isWorldQuest = isWorldQuest(questID)
 		if (isWorldQuest) then
 			ff.WorldQuestFinished (questID)
 
@@ -1357,7 +1364,7 @@ end
 
 function ff.HandleBTrackerBlock (questID, block)
 	if (not ff.BQuestTrackerUsedWidgets [block]) then
-		if (type (questID) == "number" and HaveQuestData (questID) and QuestMapFrame_IsQuestWorldQuest (questID)) then
+		if (type (questID) == "number" and HaveQuestData (questID) and isWorldQuest(questID)) then
 			local title, factionID, tagID, tagName, worldQuestType, rarity, isElite, tradeskillLineIndex = WorldQuestTracker.GetQuest_Info (questID)
 			if (not ff.cannot_group_quest [worldQuestType] and not WorldQuestTracker.MapData.GroupFinderIgnoreQuestList [questID]) then
 				--> give a button for this block
@@ -1366,7 +1373,7 @@ function ff.HandleBTrackerBlock (questID, block)
 		end
 	else
 		local isInArea, isOnMap, numObjectives = GetTaskInfo (questID) -- or not isInArea
-		if (type (questID) ~= "number" or not HaveQuestData (questID) or not QuestMapFrame_IsQuestWorldQuest (questID)) then
+		if (type (questID) ~= "number" or not HaveQuestData (questID) or not isWorldQuest(questID)) then
 			--> remove the button from this block
 			ff.RemoveButtonFromBBlock (block)
 		else