Enabled code coverage for AutoTuner smoke tests #2870
+46
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffng-or
force-pushed
the
at-enable-code-coverage2
branch
2 times, most recently
from
505af09 to
b4f9a37
Compare
vvbandeira
approved these changes
Feb 22, 2025
luarss
reviewed
Feb 22, 2025
Comment on lines
24
to
26
| self.commands = [ | ||
| f"python3 -m autotuner.distributed" | ||
| f" --design {self.design}" |
There was a problem hiding this comment.
Suggested change
| self.commands = [ | |
| f"python3 -m autotuner.distributed" | |
| f" --design {self.design}" | |
| self.commands = [ | |
| f"{self.exec}" | |
| f" --design {self.design}" |
jeffng-or
force-pushed
the
at-enable-code-coverage2
branch
from
b4f9a37 to
0b201a7
Compare
luarss
reviewed
Feb 25, 2025
| self.commands = [ | ||
| f"python3 -m autotuner.distributed" | ||
| self.exec = AutoTunerTestUtils.get_exec_cmd() | ||
| self.command = [ |
There was a problem hiding this comment.
Suggested change
| self.command = [ | |
| self.commands = [ |
fixed three typos fixed command definition Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
jeffng-or
force-pushed
the
at-enable-code-coverage2
branch
from
0b201a7 to
c02b509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaked AutoTuner test utils import. Worked locally so trying to send it through CI for verification.