Build arm containers with new github actions arm runner (PP-2139) #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
force-pushed
the
chore/workflow-arm-runner
branch
from
4de546e to
d59c20c
Compare
jonathangreen
commented
Feb 11, 2025
|
|
||
| CREATE DATABASE simplified_registry_test; | ||
| CREATE USER simplified_test WITH PASSWORD 'simplified_test'; | ||
| GRANT ALL PRIVILEGES ON DATABASE simplified_registry_test TO simplified_test; | ||
| ALTER DATABASE simplified_registry_test OWNER TO simplified_test; |
There was a problem hiding this comment.
These changes are due to the PG16 upgrade that we did, and could move out to a separate PR if desired.
Similar to changes for PG16 needed here: https://github.com/ThePalaceProject/hosting-playbook/pull/720
jonathangreen
commented
Feb 11, 2025
jonathangreen
force-pushed
the
chore/workflow-arm-runner
branch
from
d59c20c to
7f308e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR depends on #766 to update pre-commit hooks.This is merged.It is similar to ThePalaceProject/circulation#2280 and follows the same pattern.
This refactors our docker build for the library registry to use a native arm runner to build the arm version of the library registry. It follows the pattern that the circulation repo is using, moving the docker build out to its own workflow, rather than having it as part of the test workflow.
NOTE: 🚨 Right now there isn't a great way to run our tests in the docker containers before pushing them. I put a todo in for this, and there is a ticket in JIRA here PP-2142. The current workflow will unconditionally push the containers. This shouldn't be a big deal, everything merged to main should be tested before merging, so there aren't many cases where tests in container should fail. I'd like to add this in eventually, but I think it can be a follow up.
Motivation and Context
See PP-2139. This will fix broken docker builds like the one in this PR #764
How Has This Been Tested?
Checklist