Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit #766

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Update pre-commit #766

merged 2 commits into from
Feb 11, 2025

Conversation

jonathangreen
Copy link
Member

Description

This is the result of running:

pre-commit autoupdate
pre-commit run -a
git add -A
git commit

So all of the changes are automated.

Motivation and Context

Pre-commit hooks were out of date on this repo and were giving false errors about github actions when I was trying to update actions to use arm runners. So it seemed like a good idea to update it.

How Has This Been Tested?

  • Tests running in CI
  • Manually reviewed changes

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link
Collaborator

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. There is one odd choice in there, though. 🤷🏽‍♂️

model.py Outdated
Comment on lines 34 to 36
from sqlalchemy import (
func,
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an odd one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I totally missed that when I read this over. Looks like its coming from isort 6.0.0, which only came out a couple weeks ago. There is an issue in their queue that I think tags what is going on: PyCQA/isort#2352

I'll roll back isort to the last version for now, they will probably have it fixed by the time we bump pre-commit deps again.

@jonathangreen jonathangreen merged commit 92a153d into main Feb 11, 2025
8 checks passed
@jonathangreen jonathangreen deleted the chore/update-precommit branch February 11, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants