fix(android): fix bugs related Android PIP listeners

[YangJonghun]

Summary

fix(android): fix bugs related Android PIP listeners

Motivation

• Fixes bug that entire app enters PIP without player on Android 13+

• fix [BUG]: PictureInPictureUtil.calcPictureInPictureAspectRatio #4434

  • This bug occurs on Android 7 through Android 12 that use OnUserLeaveHint to enable PIP.
  • Fatal Exception: java.lang.NullPointerException : Parameter specified as non-null is null: method com.brentvatne.exoplayer.PictureInPictureUtil.calcPictureInPictureAspectRatio, parameter player

Changes

• When using onUserLeaveHint, removeOnUserLeaveHintListener was not properly removing a previously registered callback that referenced another Runnable. Fix to explicitly declare that onUserLeaveHintCallback is a Runnable so that the reference is guaranteed to be the same.
• Because all PIP listeners registered in constructor, and callback can be called before player is created, which is registered asynchronously. Modify lifecycle to match cycle in which players are created and deleted.

Test plan

Modify code like below within ReactExoplayerView

- mainHandler.postDelayed(mainRunnable, 1);
+ mainHandler.postDelayed(mainRunnable, 5000);

1. prepare the general screen, player screen, and enter the screen with the player (proceed with listener registration).
2. Enter the previous screen and delete the listener.
3. Enter the player screen again.

Verify that the PIP does not work when there is no player in steps 1 and 3, and that the PIP works correctly when there is a player.

[freeboub]

Looks good to me! @MdAbubakar by curiosity, did you test this PR ?
Edit: I sa yo already tested it, so OK for me !

[MdAbubakar]

Looks good to me! @MdAbubakar by curiosity, did you test this PR ? Edit: I sa yo already tested it, so OK for me !

@freeboub yes sir I have checked this PR and major issues are fixed but there are some other device specific and android version specific issues those are related to all these issues I think so will see afterwards if I got crashes.

@freeboub and @YangJonghun Thank you for your response.