-
-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(android): initial bitrate #4480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): initial bitrate #4480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial bitrate should be a sub property of source (or even better source.bufferConfig).
The issue here under is when you mount the
Yeah I agree - It would be better to move it into |
@freeboub Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long time to approve but it looks good to me.
Just a note for you @moskalakamil.
If I remember well this initial bitrate will be apply on player initialization (I implemented similar feature in my past fork).
During your app life cycle, if you just change <Video/>
source we don't release and recreate the whole player, then this parameter may not be used. It make sense as if exoplayer already know its expected bandwidth, no need to apply initial bandwidth.
Thank you!
Summary
Added prop to set initial bitrate
Motivation
#3074
Changes
source.bufferConfig.initialBitrate
Test plan
Run test android app with