Skip to content

Commit

Permalink
[Logs onboarding] Align elastic-agent version with stackVersion (elas…
Browse files Browse the repository at this point in the history
…tic#162622)

Closes elastic#159382.

### Changes
- `kibanaVersion` is passed as a resources to the routes.
- `elastic-agent` version is based on `kibanaVersion`.

#### Before
<img width="1073" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/00e291a2-3f8d-4d1d-9520-c0a29cc9454e">

#### After
<img width="1115" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/dffcf95f-f3a2-46f0-bb78-daebe8597b89">
  • Loading branch information
yngrdyn authored and Devon Thomson committed Aug 1, 2023
1 parent aa1fb0b commit f417511
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions x-pack/plugins/observability_onboarding/server/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export class ObservabilityOnboardingPlugin
repository: getObservabilityOnboardingServerRouteRepository(),
plugins: resourcePlugins,
config,
kibanaVersion: this.initContext.env.packageInfo.version,
services: {
esLegacyConfigService: this.esLegacyConfigService,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ import { getHasLogs } from './get_has_logs';
import { getObservabilityOnboardingState } from './get_observability_onboarding_state';
import { saveObservabilityOnboardingState } from './save_observability_onboarding_state';

const ELASTIC_AGENT_VERSION = '8.8.0'; // This should be defined from a source with the latest public release

const logMonitoringPrivilegesRoute = createObservabilityOnboardingServerRoute({
endpoint: 'GET /internal/observability_onboarding/custom_logs/privileges',
options: { tags: [] },
Expand Down Expand Up @@ -46,7 +44,7 @@ const installShipperSetupRoute = createObservabilityOnboardingServerRoute({
scriptDownloadUrl: string;
elasticAgentVersion: string;
}> {
const { core, plugins } = resources;
const { core, plugins, kibanaVersion } = resources;
const coreStart = await core.start();

const kibanaUrl =
Expand All @@ -59,7 +57,7 @@ const installShipperSetupRoute = createObservabilityOnboardingServerRoute({
return {
apiEndpoint,
scriptDownloadUrl,
elasticAgentVersion: ELASTIC_AGENT_VERSION,
elasticAgentVersion: kibanaVersion,
};
},
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ interface RegisterRoutes {
logger: Logger;
plugins: ObservabilityOnboardingRouteHandlerResources['plugins'];
config: ObservabilityOnboardingConfig;
kibanaVersion: string;
services: {
esLegacyConfigService: EsLegacyConfigService;
};
Expand All @@ -36,6 +37,7 @@ export function registerRoutes({
logger,
plugins,
config,
kibanaVersion,
services,
}: RegisterRoutes) {
const routes = Object.values(repository);
Expand Down Expand Up @@ -82,6 +84,7 @@ export function registerRoutes({
},
},
config,
kibanaVersion,
services,
})) as any;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export interface ObservabilityOnboardingRouteHandlerResources {
start: () => Promise<CoreStart>;
};
config: ObservabilityOnboardingConfig;
kibanaVersion: string;
services: {
esLegacyConfigService: EsLegacyConfigService;
};
Expand Down

0 comments on commit f417511

Please sign in to comment.