feat: add a button to change the title's font #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesL2
force-pushed
the
JulesL2/font_button
branch
from
6f00055 to
1169186
Compare
JulesL2
force-pushed
the
JulesL2/font_button
branch
2 times, most recently
from
07d40ff to
355b768
Compare
JulesL2
force-pushed
the
JulesL2/font_button
branch
from
74a4924 to
53b1ec3
Compare
JulesL2
changed the title
|
@ThomasParistech I did add some fonts with their license (OFL and Creative Commons which should be good for our use case). The PR is ready to be merged after #91 |
|
New dropdown selector for fonts
Selector when opened
Title edited
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looking for adding a selector to select the font.
It is working but still need a bit of work.
It is not ready to merge, the developments have been made on top of #91
Need to download additionnal fonts, proof of concept is here
It also works with font defined in local files by adding the declaration of the font in a CSS header
Corresponding Github Issues / Pull Requests
#94