Skip to content

fix: Small overpass processing issues for surfaces #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JulesL2
Copy link
Contributor

@JulesL2 JulesL2 commented Feb 16, 2025

Description

2 issues has been discovered:

  • When uploading tracks, I had often a warning that not all inner geometries found an outer, this was not supposed to happen and happened when multiple outer geoms exists, the variables that stores the failed inner was not well actualised.
  • When getting the inner and outer members of a relation, if there is a relation in the members, the reccursive function should inverse the role (the outer of an inner becomes an inner and the inner of an inner becomes an outer). I fix the first half, the second half need more work, a TODO mark is there.
  • Removed a warning that should never be touched thanks to improvement in the merging algorithm perf: Enhance and fix merging algorithm #76. However keep the condition to avoid a possible infinite reccursion in a unexpected situtation

@github-actions github-actions bot added the bug Something isn't working label Feb 16, 2025
@JulesL2 JulesL2 force-pushed the JulesL2/fix_overpass_processing branch from 48467a8 to 3234605 Compare February 16, 2025 18:02
@JulesL2 JulesL2 force-pushed the JulesL2/fix_overpass_processing branch from 750d8fc to 7f3512c Compare February 16, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant