Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThreeDotsLabs/watermill#445
Motivation / Background
I would like to instrument watermill-sql interactions with the database using open telemetry. Automatic instrumentation requires propagating context from callers to the database client.
Details
Message.SetContext()
can be used to propagate context to the framework, and defaults tocontext.Background()
it has not been set.Alternative approaches considered (if applicable)
I considered updating the signature of
Publish
to take a context parameter, but that would be a breaking change to watermill and all supported vendors.Checklist
The resources of our team are limited. There are a couple of things that you can do to help us merge your PR faster:
make up
.make test_short
for a quick check.make test
.