[BUG] changed error handling by using a script published by EricShulman "EditLink" in newer TW versions

[96eron]

Describe the bug

There is a changed error handling by using a script published by EricShulman "EditLink" see https://talk.tiddlywiki.org/t/how-to-quickly-navigate-to-a-transcluded-tiddler/ in TW5.3.x. In previous versions of TW (I used 5.1.23), the script EditLink triggered a error handling, which wasn't so strange. There is of course a clear error message, but limited to one line without recursive repetitions. In the newer versions it looks uncontrolled due to a changed recrusive error output.

Expected behavior

In previous versions of TW (I use 5.1.23), the script in EditLink triggered error handling, which wasn't so strange.

To Reproduce

1. create a tiddler (e.g., “EditLink”), containing:

<$button class="tc-btn-invisible" style="float:right;"
   message="tm-edit-tiddler" param=<<currentTiddler>>
   tooltip={{{ [[edit "]addsuffix<currentTiddler>addsuffix["]] }}}>
   {{$:/core/images/edit-button}}
</$button>
<$transclude mode="block"/>

2. Close it and you will see

2.(a) in TW5.1.23:
the edit icon and a red error message:
Recursive transclusion error in transclude widget
caused by the <$transclude mode="block"/> widget.

2.(b) in TW5.3.x
a repeatedly repeated printed edit symbol and the mentioned red error message: Recursive transclusion error in transclude widget

Screenshots

TW5.1.23

TW5.3.5

TiddlyWiki Configuration

• Version e.g. TW 5.1.23 vs TW5.3.5

Additional context

Referring to my previous bug report: [BUG] recursive failure in TestCaseWidget transclusion tests beginning with {{{}} #8373: may be this is a similar issue.

[pmario]

The error handling has been changed, since the "old" recursion detection was not reliable enough. It was still possible to create recursions, that could "brick" the wiki so data loss was inevitable. In v5.3.5 the new mechanism should avoid data-loss, but at the moment has some weird side effects.

As I wrote at: #8373 (comment) -- We are investigating improvements, that are reliable and show the user that something went wrong, without filling the display with unnecessary elements.

In your example Erics code has nothing to do with the error message. It's the different error handling of the transclusion-widget in v5.1.23

[pmario]

Thanks for your feedback. It points out, what is important for our users.

[96eron]

Thank you for the prompt response. But please note that the error handling has changed before TW5.3.5. As far as I can understand it, it changed from the verision 5.2.7 to 5.3.0. I say this to make sure that nothing is overlooked.
By the way:
I would like to express my my greatest respect for how this project is being managed and what has become of it.
my best wishes