Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumpvariables rewrite new syntax plus search #7992

Draft
wants to merge 78 commits into
base: master
Choose a base branch
from

Conversation

pmario
Copy link
Member

@pmario pmario commented Feb 16, 2024

This PR is a draft atm. It's "Work In Progress". These extensions where inspired by @AnthonyMuscio at Talk

  • It improves the dumpvariables macro and uses v5.3.x syntax
  • It adds a completely new search-variables macro
  • It is proposed to add the new search-variables feature to the $:/AdvancedSearch

The search-variables macro allows us to filter the list with a search text-input

For testing the PR adds a new tab to the $:/AdvancedSeach dialogue

image

The list can be extended, which opens a second search input, that shows, where the macro text is used and/or where it is defined. While working with the macro it turned out to be a very useful feature.

image

@Jermolene @saqimtiaz ... What do you think?

I'll start a new thread at Talk, to get some feedback there too, once Vercel built a preview.

@pmario
Copy link
Member Author

pmario commented Feb 16, 2024

The second input allows us to add more words to the filter string, to shorten the list

image

Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview May 23, 2024 5:51am

@pmario
Copy link
Member Author

pmario commented Feb 16, 2024

The dumpvariables macro also got a subfilter parameter

image

@pmario
Copy link
Member Author

pmario commented Feb 16, 2024

@saqimtiaz
Copy link
Member

@pmario I would highly recommend having separate PRs for new features, and for the syntax rewrite of existing macros. Especially for the latter that would make it much easier to review and merge them.

@pmario
Copy link
Member Author

pmario commented Feb 21, 2024

Yes, I can do that, since it's only 11 lines of code. Then this PR will completely rewrite it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants