-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dumpvariables rewrite new syntax plus search #7992
Draft
pmario
wants to merge
78
commits into
TiddlyWiki:master
Choose a base branch
from
pmario:dumpvariables-rewrite-new-syntax-plus-search
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dumpvariables rewrite new syntax plus search #7992
pmario
wants to merge
78
commits into
TiddlyWiki:master
from
pmario:dumpvariables-rewrite-new-syntax-plus-search
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@pmario I would highly recommend having separate PRs for new features, and for the syntax rewrite of existing macros. Especially for the latter that would make it much easier to review and merge them. |
Yes, I can do that, since it's only 11 lines of code. Then this PR will completely rewrite it. |
…g needs improvement
…srcVariable.params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft atm. It's "Work In Progress". These extensions where inspired by @AnthonyMuscio at Talk
dumpvariables
macro and uses v5.3.x syntaxsearch-variables
macroThe search-variables macro allows us to filter the list with a search text-input
For testing the PR adds a new tab to the $:/AdvancedSeach dialogue
The list can be extended, which opens a second search input, that shows, where the macro text is used and/or where it is defined. While working with the macro it turned out to be a very useful feature.
@Jermolene @saqimtiaz ... What do you think?
I'll start a new thread at Talk, to get some feedback there too, once Vercel built a preview.