Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a search button to the control panel tiddler fields tab #8157

Merged

Conversation

pmario
Copy link
Member

@pmario pmario commented Apr 19, 2024

This PR adds a new column to the ControlPanel -> Advanced -> Tiddler Fields tab.
It will copy the filter into the AdvancedSearch, so users get an overview.

grafik

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview May 14, 2024 6:30am

@pmario
Copy link
Member Author

pmario commented Apr 19, 2024

There has been a discussion at Talk lately: https://talk.tiddlywiki.org/t/list-of-all-fields-used-by-the-core/9600

It should improve the situation a bit.

Copy link
Member

@Jermolene Jermolene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmario this is a good idea, just a couple of points.

@pmario
Copy link
Member Author

pmario commented Apr 21, 2024

@Jermolene -- Updated the PR according to your suggestions

@pmario
Copy link
Member Author

pmario commented May 14, 2024

@AnthonyMuscio As a "side effect" this PR also makes search-filter-count a global macro as discussed at:

Introduce a new macro to the core, well not really - search-filter-count? #7203

@pmario
Copy link
Member Author

pmario commented Aug 4, 2024

@Jermolene -- bump

Copy link
Member

@Jermolene Jermolene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmario

@pmario
Copy link
Member Author

pmario commented Aug 4, 2024

Changed according to your remarks and made the table header translatable

grafik

Copy link
Member

@Jermolene Jermolene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmario

@pmario
Copy link
Member Author

pmario commented Aug 7, 2024

@Jermolene -- There is no table header in the current implementation, so I did remove it for this PR. It probably was a bad idea to add it in the first place.

Copy link
Member

@Jermolene Jermolene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmario

@pmario
Copy link
Member Author

pmario commented Sep 9, 2024

@Jermolene -- Merged master into this branch. It still works -- wrong "caption" field has been removed

@Jermolene
Copy link
Member

Thanks @pmario

@Jermolene Jermolene merged commit 4f4e055 into TiddlyWiki:master Sep 10, 2024
3 checks passed
@pmario pmario deleted the add-search-controlpanel-tiddler-fields branch September 10, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants