Fixed issue where $parameters did nothing with no $transclude #8203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you @flibbles I agree, this is a very worthwhile fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered this problem when creating a new TiddlyMap release.
If you try to directly render a tiddler (such as by using
$tw.wiki.renderTiddler) that has\parametersor<$parameters>in it, the parameters widget will do nothing. It'll look up its parent tree, find no transclude to possibly pull arguments from, and just disable itself.I'm not sure this should be expected behavior. For instance, TiddlyMap now has to do a weird workaround for this just so it can render the
$:/core/images/tag-buttoninto a usable form for svg icons. I would think expected behavior for $parameters would be to use its default parameters in such a case. It certainly makes sense for icons.