-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide examples for the wikify widget #8792
Provide examples for the wikify widget #8792
Conversation
@DesignThinkerer It appears that this is your first contribution to the project, welcome. With apologies for the bureaucracy, please could you prepare a separate PR to the 'tiddlywiki-com' branch with your signature for the Contributor License Agreement (see contributing.md). |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…Cases_WikifyWidget_WidgetValue_Fail.tid
…estCases_WikifyWidget_WidgetValue_Success.tid
I think the first example should be something that works. It is OK to show how we should not do it, but it needs much more explanation, what we want to show. If the first example is a fail users think it is broken. If we want to show "failed examples" it needs a detailed description, what's going on. |
fix small error causing validation to fail
I think it looks more readable now. But the https://deploy-preview-8792--tiddlywiki-previews.netlify.app/#TestCases%2FWikifyWidget%2FWidgetValue%2FSuccess fails. You need to remove the very last new-line in the file - then it works
|
@pmario good catch, it is now fixed :) (edit: there was another testcase with a trailing line, I fixed it) |
editions/tw5.com/tiddlers/TestCases_WikifyWidget_RenderHTML.tid
Outdated
Show resolved
Hide resolved
DesignThinkerer has signed the Contributor License Agreement (see contributing.md) |
Great stuff, thank you @DesignThinkerer |
This PR add examples for using the wikify widget. Discussion: https://talk.tiddlywiki.org/t/doc-wikifywidget-examples-usecase/5890
Submitted using https://saqimtiaz.github.io/tw5-docs-pr-maker/.