Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RSoD error with moduleproperty filter operator #8958

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

flibbles
Copy link
Contributor

Found this while working with this filter operator. If you try to pull properties from tiddlers that aren't actually modules, then you get a crash.

Hope this operator wasn't an afterthought. This seemed like a pretty obvious bug, and there weren't any tests for it at all.

Let me know if this isn't the preferred fix.

Copy link

Confirmed: flibbles has already signed the Contributor License Agreement (see contributing.md)

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 494bce9
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/67b808c28a580e0007506976
😎 Deploy Preview https://deploy-preview-8958--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flibbles
Copy link
Contributor Author

I have added another commit to this so that there is no longer a RSoD when you fetch a non-string property either.

Instead, the operator will JSON.stringify the property and return it. I would like to see this behavior, because it would be super useful for me to query my graph visualization engines for what features they can do. All part of my upcoming super-cool graph plugin designed to replace TiddlyMap.

@Jermolene
Copy link
Member

Thanks for your patience @flibbles, looks good.

@Jermolene Jermolene merged commit 636dae6 into TiddlyWiki:master Mar 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants