Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problem toc-selective-expandable #8959

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

pmario
Copy link
Member

@pmario pmario commented Feb 21, 2025

fix problem toc-selective-expandable

This PR fixes the problem described at Talk: https://talk.tiddlywiki.org/t/issue-using-toc-selective-expandable-with-exclude/11972

<div class="tc-table-of-contents">
<<toc-selective-expandable 'TableOfContents' exclude:'[tag[done]]'>>
</div>
  • I then changed the Videos tiddler to have tag “done”. While this excluded the Videos tiddler under the Learning tiddler in the Contents tab, the “expandable arrow” disappears too, which seems like a bug?

7e0b019eb551d19c817b009325039e6b08896a26

fix problem toc-selective-expandable
Copy link

Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md)

@pmario
Copy link
Member Author

pmario commented Feb 21, 2025

Kudos go to @ericshulman -- Can you please test?

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 777e919
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/67b8a16445616200086915c6
😎 Deploy Preview https://deploy-preview-8959--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jermolene
Copy link
Member

Thanks @pmario

@Jermolene Jermolene merged commit 0f79f88 into TiddlyWiki:master Feb 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants