[MWS] Cleanup linter errors in mws server plugin #8965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iddlyWiki#8898) * Bug fix: TTF extension was wrong. * Update font MIME types throughout; add font/otf.
Adds `shadow` and `normal` flags to each entry in `changedTiddlers`, indicating whether the corresponding version of the tiddler has changed. Makes the saver handler ignore any changes that aren't flagged `normal`. Fixes TiddlyWiki#8902.
* chore: cleanup cruft from edit widget * chore: cleanup cruft from edit widget * chore: cleanup cruft from edit widget
* fix: handle attributes correctly in genesis widget * fix: handle attributes correctly in genesis widget
…iddlyWiki#8912) * Extend copy to clipborad function to support customized mime types * Remove function default parameter syntax * Add plainText option * Use plainText name * Set "text/plain" data only when it exists * Docs update * Docs update
* Flexoki palette update * Improve highlight contrast
…ixes (TiddlyWiki#8949) * [DOCS] Crosslink, then / else Operators, :then / :else Fiter Run Prefixes * Update else Operator.tid * Update Else Filter Run Prefix.tid * Update then Filter Run Prefix.tid * Update then Operator.tid
…ki.com (TiddlyWiki#8940) * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\definitions\TiddlyDesktop.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\platforms\Platforms.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\TiddlyWiki on Node.js.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\Building TiddlyWikiClassic.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\Installing TiddlyWiki Prerelease on Node.js.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\commands\NamedCommandParameters.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\Upgrading TiddlyWiki on Node.js.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\howtos\Using a custom path prefix with the client-server edition.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\Customising Tiddler File Naming.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\Environment Variables on Node.js.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\howtos\Generating Static Sites with TiddlyWiki.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\howtos\How to build a TiddlyWiki5 from individual tiddlers.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\Installing custom plugins on Node.js.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\Installing official plugins on Node.js.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\saving\Example config-tiddlyweb-host for IIS.txt' * [ja-JP] Japanese translation of 'editions\ja-JP\tiddlers\saving\Example package.json for IIS.txt' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\saving\Example tiddlywiki.info for IIS.txt' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\saving\Example web.config for IIS.txt' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\fileformats\MultiTiddlerFiles.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\fileformats\MultiTiddlerFileSyntax.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\Scripts for TiddlyWiki on Node.js.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\fileformats\TiddlerFiles.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\tiddlywiki.files_Files.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\tiddlywiki.info_Files.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\concepts\TiddlyWikiFolders.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\Uninstalling a plugin with Node.js.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\howtos\Using TiddlyWiki for GitHub project documentation.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\Using TiddlyWiki on Node.js.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\nodejs\Working with the TiddlyWiki5 repository.tid' * [ja-JP] Japanese translation of 'editions\tw5.com\tiddlers\plugins\Plugin Ordering.tid'
…iddlyWiki#8935) * [DOCS] HelloThere. Add info about the core nature of TW as a web-app * Update HelloThere.tid
* [DOCS] Fix link to external blog post about TW * Update Future Proof.tid
$fill widgets will get ignored when encountered by ts-raw slots
* Correct noscript fallback for Empty Edition Also slightly improve the Mastodon link text (since it'll be read by people without JS) Before this patch, if the "built-in" Empty Edition was downloaded then the Mastodon verification link was included, which is wrong. Not a super big deal since it'll get "flushed out" the first time the user saves, but still confusing. The mastodon link could've just been moved inside the <$reveal> but I think it's better to try to achieve parity with tiddlywiki.com/empty.html; This commit does not achieve parity but it gets us closer. * Remove whitespace from conditional shortcut syntax Conform to style used in TiddlyWiki#8583 as suggested by https://github.com/TiddlyWiki/TiddlyWiki5/pull/8924/files#r1938181043
* Fix incorrect downloaded file extension * Update docs
* [DOCS] Fix duplicate link in: HTML in Wikitext * Update HTML in WikiText.tid
* Add system-ui to default font family * Make system-ui's priority lower
…e filter-expressions (TiddlyWiki#8729) * [DOCS] Make it more obvious that $:/DefaultTiddlers setting can handle filter-expressions * update with requested changes. * [DOCS] Make it more obvious that $:/DefaultTiddlers setting can handle filter-expressions * Refactor text according to feedback * Create link to DefaultTiddlers system tiddler
* Remove flags in language plugins * Remove references to language icons * Remove obsolete example There are no incoming links to this tiddler * Remove icon from en-GB language * Temporarily add all the languages for testing To be removed before merging * Add new "language" icon * Languageswitcher update * Translator editon docs update * Fixes for introduction edition * Remove LanguageGallery in ja-JP edition * Remove temporary setting --------- Co-authored-by: Jeremy Ruston <jeremy@jermolene.com>
fix problem toc-selective-expandable
…tion for $tw, setup jsfonfig.json to map $:/ paths to file system paths
|
Confirmed: joshuafontany has already signed the Contributor License Agreement (see contributing.md) |
❌ Deploy Preview for tiddlywiki-previews failed.
|
|
Hmm, tests are failing. Need to resolve that, and maybe cleanup the MWS client plugin folder. |
The error turned out to be related to this one, we need to wait the upstream mws branch to merge from master. |
|
All Local tests are passing if I set the Anonymous read/write configuration tiddlers to yes. The file upload tests failed otherwise. I don't think those configs should be in the "multiwikiserver" edition admin wiki tiddlers folder by default tho. Do we need a "multiwikiserver-test" edition? Do we use the existing "test" edition for these types of tests? |
|
@Jermolene My forked now includes a merge from main to this branch, so this PR got spammy. Once you merge main into your mws branch, I can clean this up to just the new changes. |
Hi @joshuafontany that's done, let me know if this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup linter errors in mws server plugin, prep for using tw as a dependency in MWS standalone repo.