Skip to content

Commit b8773f4

Browse files
committed
Allow mixed warning - error summary
1 parent 2b551ed commit b8773f4

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

sqlmesh/integrations/github/cicd/command.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ def _run_all(controller: GithubController) -> None:
192192

193193
controller.update_linter_check(status=GithubCheckStatus.QUEUED)
194194

195-
lint_error = controller._linter_errors is not None
195+
lint_error = controller._linter_error
196196

197197
controller.update_linter_check(
198198
status=GithubCheckStatus.COMPLETED,

sqlmesh/integrations/github/cicd/controller.py

+3-5
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ def __init__(
302302
self._prod_plan_builder: t.Optional[PlanBuilder] = None
303303
self._prod_plan_with_gaps_builder: t.Optional[PlanBuilder] = None
304304
self._check_run_mapping: t.Dict[str, CheckRun] = {}
305-
self._linter_errors = None
305+
self._linter_error = False
306306

307307
if not isinstance(get_console(), MarkdownConsole):
308308
raise CICDBotError("Console must be a markdown console.")
@@ -670,13 +670,11 @@ def update_linter_check(
670670
def conclusion_handler(
671671
conclusion: GithubCheckConclusion,
672672
) -> t.Tuple[GithubCheckConclusion, str, t.Optional[str]]:
673-
test_summary = (
674-
self._linter_errors or self._console.consume_captured_output() or "Linter Success"
675-
)
673+
linter_summary = self._console.consume_captured_output() or "Linter Success"
676674

677675
title = "Linter results"
678676

679-
return conclusion, title, test_summary
677+
return conclusion, title, linter_summary
680678

681679
self._update_check_handler(
682680
check_name="SQLMesh - Linter",

0 commit comments

Comments
 (0)