Fix!: pass dialect to annotate_types and simplify #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
force-pushed
the
jo/pass_dialect_to_optimizer_funcs
branch
from
ae3b50a to
a316530
Compare
tobymao
approved these changes
Mar 25, 2025
georgesittas
force-pushed
the
jo/pass_dialect_to_optimizer_funcs
branch
from
a316530 to
7bf4a82
Compare
georgesittas
force-pushed
the
jo/pass_dialect_to_optimizer_funcs
branch
from
7bf4a82 to
b174865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations are sensitive to the dialect, e.g. BigQuery overrides
ANNOTATORS. Same forsimplify, e.g.COALESCEsimplification depends on the dialect.