Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add CICD bot check for linting #4027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat: Add CICD bot check for linting #4027

wants to merge 1 commit into from

Conversation

VaggelisD
Copy link
Contributor

@VaggelisD VaggelisD commented Mar 25, 2025 •
edited
Loading

This PR enhances the CI/CD bot with a new check specific to the linter.

For the new check, we have the following cases:

  • If linting is disabled, the check does not run at all

  • If linting is fully successful, the check passes with Linter Success

  • If linting shows error/warning outputs, the summary is as shown below:

  • Linter errors

linter_errors

  • Linter warnings
linter_warnings

@VaggelisD VaggelisD requested a review from a team March 25, 2025 16:07
georgesittas
georgesittas approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@georgesittas georgesittas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable, although I'm not super familiar with the CICD bot's code in general. Left a few questions to understand things a bit better.

@VaggelisD VaggelisD force-pushed the vaggelisd/cicdbot_linter branch from b8773f4 to 8f2b7ee Compare March 25, 2025 17:59
@VaggelisD
Copy link
Contributor Author

VaggelisD commented Mar 25, 2025 •
edited
Loading

Note: #4032 actually solves the initial problem.

This PR should now be rebased on top of it & divert the output to the new linter check/job.

@VaggelisD VaggelisD marked this pull request as draft March 26, 2025 14:10
@VaggelisD VaggelisD force-pushed the vaggelisd/cicdbot_linter branch 4 times, most recently from ba0b56d to 7e6eba6 Compare March 28, 2025 21:46
@VaggelisD VaggelisD marked this pull request as ready for review March 28, 2025 21:58
@VaggelisD VaggelisD force-pushed the vaggelisd/cicdbot_linter branch from 7e6eba6 to 2cf6f51 Compare March 28, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

@kelsin kelsin kelsin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VaggelisD @kelsin @georgesittas