Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for chords when using Sequence, use nested arrays to use chords #1219

Closed
wants to merge 1 commit into from

Conversation

arjuna-dev
Copy link

  1. Please make all pull requests on the dev branch.
  2. Don't commit build files
  3. Try to get all tests to pass.

@tambien
Copy link
Contributor

tambien commented Feb 18, 2025

Thanks for the CL, but i think this would break the Sequence syntax. What i've done in the past for making sequences of chords was to use chord symbols (e.g. ["C", "Am", "Dm", "G"]) and then define a Map which maps the chord name to the array of notes

@tambien tambien closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants