port js to ts #1270
Merged
port js to ts #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pano9000
reviewed
Feb 25, 2025
| @@ -26,13 +37,13 @@ export default class RightDropdownButtonWidget extends BasicWidget { | |||
| }; | |||
| } | |||
|
|
|||
| doRender() { | |||
| doRender(): void { | |||
There was a problem hiding this comment.
I don't think there's a need to explicitly declare the return type of functions here.
I personally don't mind it, but I haven't seen that being done across the TriliumNext codebase, but I'll leave it to @eliandoran to decide :-)
There was a problem hiding this comment.
@pano9000 , indeed generally it's not needed.
The only case when we should add is when the return type is non-obvious (i.e. there are multiple return points, each forming the data in a different way).
eliandoran
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.