Support for 1.21.3

- Added support for Minecraft 1.21.3
- Added loop entries for scoreboard enables
- Updated GitHub workflow

Author: Tschipcraft

.github/workflows/cd.yml

@@ -96,7 +96,7 @@ jobs:
 
           name: "[DP] Release v${{ github.event.inputs.tag }}"
           version: ${{ github.event.inputs.tag }}
-          changelog-file: CHANGES.*
+          changelog-file: CHANGES.md
 
           loaders: |
             datapack
@@ -115,7 +115,7 @@ jobs:
 
           name: "[Mod] Release v${{ github.event.inputs.tag }}"
           version: ${{ github.event.inputs.tag }}+mod
-          changelog-file: CHANGES.*
+          changelog-file: CHANGES.md
 
           dependencies: |
             fabric-api(optional){modrinth:P7dR8mSH}
@@ -141,7 +141,7 @@ jobs:
 
           name: "Release v${{ github.event.inputs.tag }}"
           version: ${{ github.event.inputs.tag }}
-          changelog-file: CHANGES.*
+          changelog-file: CHANGES.md
 
           loaders: |
             datapack
@@ -160,7 +160,7 @@ jobs:
 
           name: "Release v${{ github.event.inputs.tag }}"
           version: ${{ github.event.inputs.tag }}+mod
-          changelog-file: CHANGES.*
+          changelog-file: CHANGES.md
 
           dependencies: |
             catalogue(optional){curseforge:459701}

.github/workflows/test_workflow.yml

@@ -9,11 +9,11 @@ on:
       mc_version:
         description: 'Minecraft version(s) the data pack runs in (human readable)'
         required: true
-        default: '1.17x-1.20x'
+        default: '1.17x-1.21x'
       mc_version_range:
         description: 'Minecraft version(s) the data pack runs in (encoded in version range spec)'
         required: true
-        default: '>=1.17 <=1.20.4'
+        default: '>=1.17 <=1.21'
 
 jobs:
   deploy:

.spyglassrc.json

@@ -0,0 +1,9 @@
+{
+  "env": {
+    "gameVersion": "1.21"
+  },
+  "lint": {
+    "idOmitDefaultNamespace": ["warning", false],
+    "nbtTypeCheck": ["warning", "strictly"]
+  }
+}

CHANGES.md

@@ -1,5 +1,6 @@
-- Added Curios API and Curios API Continuation support (closes [#52](https://github.com/Tschipcraft/dynamiclights/issues/52))
-- Added global and per-player toggle for Dynamic Lights (closes [#56](https://github.com/Tschipcraft/dynamiclights/issues/56), closes [#37](https://github.com/Tschipcraft/dynamiclights/issues/37), closes [#26](https://github.com/Tschipcraft/dynamiclights/issues/26), closes [#47](https://github.com/Tschipcraft/dynamiclights/issues/47))
+- **Added support for Minecraft 1.21.3** 💰
+- **Added Curios API and Curios API Continuation support** (closes [#52](https://github.com/Tschipcraft/dynamiclights/issues/52))
+- **Added global and per-player toggle for Dynamic Lights** (closes [#56](https://github.com/Tschipcraft/dynamiclights/issues/56), closes [#37](https://github.com/Tschipcraft/dynamiclights/issues/37), closes [#26](https://github.com/Tschipcraft/dynamiclights/issues/26), closes [#47](https://github.com/Tschipcraft/dynamiclights/issues/47))
 - Added mod support for Lucky's Wardrobe
 - Fixed ominous item spawners not being parsed for light emitting items
 - Fixed Dynamic Lights breaking after some time on paper servers (closes [#45](https://github.com/Tschipcraft/dynamiclights/issues/45), closes [#21](https://github.com/Tschipcraft/dynamiclights/issues/21))

data/dynamiclights/function/install.mcfunction

@@ -74,5 +74,6 @@ scoreboard players set dynamiclights load.status 18
 advancement revoke @a only tschipcraft:menu
 advancement revoke @a only dynamiclights:toggle_enable
 
-## Schedule main function
+## Schedule main and loop function
 schedule function dynamiclights:internal/main 5t
+schedule function dynamiclights:internal/loop 10s

data/dynamiclights/function/internal/loop.mcfunction

@@ -0,0 +1,7 @@
+##by Tschipcraft
+# Loop to ensure all new players can run the triggers
+
+schedule function dynamiclights:internal/loop 4s
+
+scoreboard players enable @a ts.dl.toggle
+scoreboard players enable @a tschipcraft.menu

data/dynamiclights/function/internal/main.mcfunction

@@ -1,4 +1,4 @@
-## by Tschipcraft
+##by Tschipcraft
 
 # Schedule for next tick
 schedule function dynamiclights:internal/main 1t

data/dynamiclights/function/internal/version_checker/start.mcfunction

@@ -2,7 +2,8 @@
 
 scoreboard objectives add ts.dl.version dummy
 execute store result score $global ts.dl.version run data get entity @r DataVersion
-execute unless score $global tvc_ignore matches 1 if score $global ts.dl.version matches 4000.. run tellraw @a [{"text":"[Dynamic Lights] ","color":"gray"},{"text":"?","bold":true,"color":"gold"},{"text":" Future unknown Minecraft version above 1.21 detected! This data pack/mod may not work correctly anymore! Please make sure to check for updates in the menu! (","color":"gold"},{"text":"/trigger tschipcraft.menu","underlined":true,"color":"gold","clickEvent":{"action":"run_command","value":"/trigger tschipcraft.menu"},"hoverEvent":{"action":"show_text","contents":"Click here"}},{"text":")","color":"gold"}]
+execute unless score $global tvc_ignore matches 1 if score $global ts.dl.version matches 4100.. run tellraw @a [{"text":"[Dynamic Lights] ","color":"gray"},{"text":"?","bold":true,"color":"gold"},{"text":" Future unknown Minecraft version above 1.21.3 detected! This data pack/mod may not work correctly anymore! Please make sure to check for updates in the menu! (","color":"gold"},{"text":"/trigger tschipcraft.menu","underlined":true,"color":"gold","clickEvent":{"action":"run_command","value":"/trigger tschipcraft.menu"},"hoverEvent":{"action":"show_text","contents":"Click here"}},{"text":")","color":"gold"}]
+# Note: 1.17x-1.20x uses the old folder names (function -> functions)
 
 # Curios Compatibility
 scoreboard players reset $curios_install ts.dl.version

data/dynamiclights/functions/install.mcfunction

@@ -75,7 +75,7 @@ scoreboard players set dynamiclights load.status 18
 advancement revoke @a only dynamiclights:interacted_with_item_frame
 advancement revoke @a only dynamiclights:toggle_enable
 
-## Schedule functions
+## Schedule main and loop function
 schedule function dynamiclights:internal/main 5t
 schedule function dynamiclights:internal/loop 4t
 

data/dynamiclights/functions/internal/loop.mcfunction

@@ -1,6 +1,10 @@
 ##by Tschipcraft
-# Resets dynamic item holders such as item frames
 
+schedule function dynamiclights:internal/loop 4s
+
+# Reset dynamic item holders such as item frames
 scoreboard players reset @e[type=#dynamiclights:reparse] ts.dl.i.type
 
-schedule function dynamiclights:internal/loop 4s
+# Ensure all new players can run the triggers
+scoreboard players enable @a ts.dl.toggle
+scoreboard players enable @a tschipcraft.menu

data/dynamiclights/functions/internal/main.mcfunction

@@ -1,4 +1,4 @@
-## by Tschipcraft
+##by Tschipcraft
 
 # Schedule for next tick
 schedule function dynamiclights:internal/main 1t

data/dynamiclights/functions/internal/version_checker/start.mcfunction

@@ -2,6 +2,7 @@
 
 scoreboard objectives add ts.dl.version dummy
 execute store result score $global ts.dl.version run data get entity @r DataVersion
+# Note: 1.21+ uses the new folder names (functions -> function)
 #execute if score $global ts.dl.version matches 2976..3106 run say 1.19 detected!
 #execute if score $global ts.dl.version matches 2731..2975 run say 1.18 detected!
 #execute if score $global ts.dl.version matches 2587..2730 run say 1.17 detected!

pack.mcmeta

@@ -2,7 +2,7 @@
   "id": "dynamiclights",
   "pack": {
     "pack_format": 15,
-    "supported_formats": [7,48],
+    "supported_formats": [7,57],
     "description": "Tschipcraft's Dynamic Lights \n└ v${version} ● mc${mc_version}"
   },
   "overlays": {