Cache expire should always be an int, this also fixes bbangert#71 which provided an example with str expire

Author: amol-

beaker/cache.py

@@ -283,6 +283,10 @@ def __init__(self, namespace, type='memory', expiretime=None,
                 raise cls
         except KeyError:
             raise TypeError("Unknown cache implementation %r" % type)
+
+        if expire is not None:
+            expire = int(expire)
+
         self.namespace_name = namespace
         self.namespace = cls(namespace, **nsargs)
         self.expiretime = expiretime or expire

tests/test_cachemanager.py

@@ -145,19 +145,46 @@ def test_cache_region_has_default_key_length():
         assert 'short_term_without_key_length' in cache_regions
 
         @cache.region('short_term_without_key_length')
-        def load(person):
+        def load_without_key_length(person):
             now = datetime.now()
             return "Hi there %s, its currently %s" % (person, now)
 
         # Ensure that same person gets same time
-        msg = load('fred')
-        msg2 = load('fred')
+        msg = load_without_key_length('fred')
+        msg2 = load_without_key_length('fred')
         assert msg == msg2, (msg, msg2)
 
         # Ensure that different person gets different time
-        msg3 = load('george')
+        msg3 = load_without_key_length('george')
         assert msg3.split(',')[-1] != msg2.split(',')[-1]
 
     finally:
         # throw away region for this test
         cache_regions.pop('short_term_without_key_length', None)
+
+
+def test_cache_region_expire_is_always_int():
+    try:
+        cache = CacheManager(cache_regions={
+            'short_term_with_string_expire': {
+                'expire': '60',
+                'type': 'memory'
+            }
+        })
+
+        # Check CacheManager registered the region in global regions
+        assert 'short_term_with_string_expire' in cache_regions
+
+        @cache.region('short_term_with_string_expire')
+        def load_with_str_expire(person):
+            now = datetime.now()
+            return "Hi there %s, its currently %s" % (person, now)
+
+        # Ensure that same person gets same time
+        msg = load_with_str_expire('fred')
+        msg2 = load_with_str_expire('fred')
+        assert msg == msg2, (msg, msg2)
+
+    finally:
+        # throw away region for this test
+        cache_regions.pop('short_term_with_string_expire', None)