Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Safari bug on rendering of box-shadow #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enfascination
Copy link

This change fixes Issue #16 (at least for me)

This change fixes Issue TurkServer#16 (at least for me)
@mizzao
Copy link
Member

mizzao commented Apr 7, 2017

Hey @enfascination, I've been a little too busy to review all pull requests lately, so I gave you commit access to make any changes you'd like. It would be nice to follow the style used by the rest of the code and make sure you test this in different browsers using the demo app, just to make sure everything works as before.

If you give me your Meteor developer username, I can give you permission to publish a new version of this package as well. Thanks!

@mizzao
Copy link
Member

mizzao commented Apr 7, 2017

@enfascination BTW: would love to talk to you about experimenting with societies and governance sometime. I was discussing this with @ejolly and he mentioned you gave him the idea. I am planning for how we might run these experiments via multiplayer games: https://www.scienceathome.org/community/blog/new-collaborator-andrew-mao/

@enfascination
Copy link
Author

enfascination commented Apr 7, 2017 via email

@mizzao
Copy link
Member

mizzao commented Apr 7, 2017

A few ideas:

  • What if you use Stylus or Sass mixins to generate the right CSS instead of having to prefix it yourself? (could just use the Meteor package.)
  • Feel free to just kill the border radius if you'd like if it fixes the shadow on all browsers
  • Alternatively, feel free to try anything else if it achieves the same effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants