Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap:i18n added with French translation (default en) #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

guidouil
Copy link
Collaborator

@guidouil guidouil commented Oct 5, 2014

So here it is, the text in english is yours and I did add the package, it's files and the french translation.
Thanks

@mizzao
Copy link
Member

mizzao commented Oct 23, 2014

What is "translation_function_name": "__" for? It doesn't seem to be used anywhere.

I wonder if it's possible to design this as a weak dependency so that if tap is not part of the package, the _ helper just pulls out the English text by default. Or do you think that is worth it?

@mizzao
Copy link
Member

mizzao commented Jun 29, 2016

Hi @guidouil - I apologize for the extremely long delay on this.

I have been too busy to maintain this project effectively, so I gave you commit access to make any changes you'd like. It would be nice to follow the style used by the rest of the code and add some tests to this patch.

If you'd like permission to publish the package to Meteor as well, please send me your Meteor developer username.
If you'd like permission to publish the package to Meteor as well, please send me your Meteor developer username.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants