Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLANK Corner Color #74

Open
sjtrny opened this issue Mar 21, 2024 · 0 comments
Open

BLANK Corner Color #74

sjtrny opened this issue Mar 21, 2024 · 0 comments

Comments

@sjtrny
Copy link
Contributor

sjtrny commented Mar 21, 2024

Describe the bug

There are two related issues related to BLANK corner colors:

  1. calling paint_corner with color BLANK fails because it is assigned an empty string and inside paint_corner the color string is checked against None.
  2. the blank corner color string is hardcoded and scattered throughout the library, this should probably reference an enum value which is set in one location

Expected behavior

Calling paint_corner(BLANK) should not throw an exception since BLANK is a valid color code.

Additional context

Created issue to track TODO items arising from #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant