Skip to content

Commit e6b819e

Browse files
authored
Merge pull request #77 from UBC-MDS/shlrley-ms4-finaledits
Cut down to 500 words
2 parents 6be0f0a + 8248c80 commit e6b819e

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

docs/reflection-milestone4.md

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,18 @@
11
## Milestone 4 Reflection
22

3-
Project Title: VanArt
4-
5-
Group Members:
6-
- Robin Dhillon
7-
- Shirley Zhang
8-
- Lisa Sequeira
9-
- Hongjian Li
10-
11-
### What we have done so far?
3+
### Done so far?
124

135
*Improvements implemented in Milestone 4*
146

157
1. We added a `navbarPage` panel to create a "Dashboard" page which holds our main dashboard, and an "About" page which gives the user information about our dashboard.
168
2. We accounted for the edge cases when there are no artworks depending on the user's inputs and thus, the whole world map would be displayed. Now when this happens, all the public art in Vancouver is displayed (like default case) and a notification is displayed (duration of 30s) which tells the user that no art exists for the current user input.
17-
3. Added three different types of maps for the main leaflet map. The user can now toggle between a `Basemap`, a `Neighbourhood` map which shows the different neighbourhoods unlike `Basemap`, as well as a `Satellite` map which gives a satellite view.
9+
3. Added three different types of maps for the main leaflet map. The user can now toggle between a `Basemap`, a `Neighbourhood` map showing the different neighbourhoods (unlike `Basemap`), as well as a `Satellite` map which gives a satellite view.
1810
4. Updated the README (added installation instructions, badges, and more) and proposal to reflect the most up-to-date dashboard.
1911
5. Added a download button which could allow user to download the filtered data-set base on what they selected on our dashboard.
20-
6. Although our dashboard responds very fast to user input, we also added spinners/progress bars to create a complete, production ready app
12+
6. Although our dashboard responds very fast to user input, we also added spinners/progress bars to create a complete, production ready app.
2113
7. Updated theme and all applicable visualization with the color theme "cerulean".
2214

23-
### What are limitations of our dashboard? What is yet to be implemented?
15+
### Limitations of our dashboard? Yet to be implemented?
2416

2517
1. For some art pieces, there is no image available even when we have a link. Due to this, the image embedding in the popup doesn't show an image. Accounting for this has yet to be implemented as this has turned out to be quite difficult.
2618
2. At the beginning of milestone 4, we thought about including a choropleth map but that would require another dataset with boundaries of Vancouver neighbourhoods. Currently, we don't have that but it definitely could be implemented in the future.
@@ -37,6 +29,6 @@ Group Members:
3729

3830
- Color scheme can be changed and title(s) of plots can be made larger.
3931

40-
### Is there any feedback (or other insight) that you have found particularly valuable during your dashboard development?
32+
### Feedback (or other insight) that you have found particularly valuable during your dashboard development?
4133

4234
- Yes, the aforementioned edge case scenarios when there is no art depending on the user's inputs.

0 commit comments

Comments
 (0)