Leftovers. #282
Merged
Leftovers. #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few minor things we discussed in person but that I didn't make a ticket for. Also a bit of a review of the text in the website's index.html.
samcunliffe
requested review from
dstansby,
matt-graham,
paddyroddy,
sfmig and
mxochicale
matt-graham
approved these changes
Jan 24, 2024
Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just before I forget: a few minor/trivial things we discussed in person but that I didn't make a ticket for 🤦.
I also did a bit of a review of the text in the website's index.html. Mainly adding a mention of our template amongst the discussion of "use the community templates". It's a bit WET from the packaging page, but there's already a bit of duplication there and it's all probably sane from the point of view of a reader.
I spotted a line that should have gone with #271 and a post-merging comment on #264.