Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change github_user to github_user_or_org #300

Closed
wants to merge 1 commit into from
Closed

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Feb 6, 2024

I didn't realise that the intent of this variable was to be the username or organisation where the git repository is remotely located. So when I ran the cookiecutter I put in my username, then had to change it all to the org I was actually using.

Hopefully this PR makes it clearer that this variable can be a username or an organisation.

@samcunliffe
Copy link
Member

samcunliffe commented Feb 6, 2024

Should we stick to the GH jargon and use "owner"?

Screenshot 2024-02-06 at 14 31 24

... dunno though. It's not necessarily clearer...?

@dstansby
Copy link
Member Author

dstansby commented Feb 6, 2024

Hmm, I'm 👍 to using existing terms, but I wouldn't have known off the top of my head (before reading your comment) what a GitHub owner was. Maybe worth asking a few others if they would know what "owner" meant?

@paddyroddy
Copy link
Member

Related to #296

@@ -5,7 +5,7 @@ title: "[BUG]: "
labels:
- bug
assignees:
- "{{cookiecutter.github_username}}"
- "{{cookiecutter.github_user_or_org}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can an organisation be assigned as bug ticket?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean can an organisation the assignee on a GitHub issue? I don't think so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what I meant. 8 am pre-coffee grammar. Sorry.

@dstansby
Copy link
Member Author

Related to #296

👍 I think solving the underlying issue here (github_user not covering all possibilities) is best done by adding human readable prompts, so I'll close this PR and open an issue (which I should have done first anyway, sorry...)

@dstansby dstansby closed this Feb 15, 2024
@paddyroddy
Copy link
Member

Close branches please
image

@paddyroddy paddyroddy deleted the allow-gh-org branch February 16, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants