Validate GitHub issue templates #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
requested changes
Feb 19, 2024
paddyroddy
reviewed
Feb 19, 2024
.pre-commit-config.yaml
Outdated
| @@ -56,3 +56,12 @@ repos: | |||
| args: | |||
| - --fix=lf | |||
| - id: trailing-whitespace | |||
| - repo: https://github.com/python-jsonschema/check-jsonschema | |||
| rev: cb934cfd6d2eea1aed7b20e4e9e6339d5952322c # 0.28.0 | |||
There was a problem hiding this comment.
I assume renovate will use this syntax in the future. How does this play with pre-commit autoupdate?
There was a problem hiding this comment.
😢 pre-commit autoupdate doesn't like it, and just changes it back to a version number. So I've switched the SHAs to version numbers.
There was a problem hiding this comment.
Yeah, I thought that might be the case. The pre-commit maintainer is pretty stubborn, too, so he likely won't change the format.
paddyroddy
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validates the GitHub issue tempaltes against a schema, and would have caught the issue that was fixed by #306.
Unfortunately it's not possible to validate the package template files as they contain invalid characters for a string entry (
{and}).