-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MkDocs docs to template #319
Conversation
I got a not very helpful If we're going the MkDocs route, I would say we might want to review use of Prettier for YAML files as I can imagine the experience for users of getting a message like this when trying to commit changes to Prettier output
|
I do think a lot of the difficulties arise from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case we go with this approach, I have given a review.
Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com>
Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com>
Co-authored-by: Patrick J. Roddy <patrickjamesroddy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for dual-wielding the docs builds!
Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Following the discussion in #16, I've tried to summarise (and might have quoted you directly 😄). Picky comments very gratefully received. ## Fixes - #187 ## Relates to - #16 - #318 - #319 --------- Co-authored-by: Matt Graham <matthew.m.graham@gmail.com> Co-authored-by: David Stansby <dstansby@gmail.com>
Would resolve #16 as an alternative to #318
Adds MkDocs documentation to template, aiming for a comparable set of features to what is implemented in #318 - automatically built API documentation with Markdown syntax, support for references to external documentation inventories, dark / light mode toggle, GitHub repository link in docs, workflow for automatically testing building docs.
Example screenshot of rendered index page
and of API reference page