Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Correct uses of project_name in pyproject.toml" #326

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

dstansby
Copy link
Member

Reverts #309. It turns out this was incorrect... source: a new package I just made. maybe at some point we should add some regression tests for the contents of pyproject.toml?

Copy link
Member

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old module/package/slug confusion? Yeah, it's a bit disturbing that we didn't have a test that failed for #309.

add some regression tests for the contents of pyproject.toml?

Are you thinking just a simple diff with an expected output? We could try to test some edge cases, at least (different project name w.r.t. slug with spaces).

@paddyroddy
Copy link
Member

Reverts #309. It turns out this was incorrect... source: a new package I just made. maybe at some point we should add some regression tests for the contents of pyproject.toml?

I was surprised when you said this wasn't working! But blindly trusted, so yes we need a test.

@dstansby
Copy link
Member Author

Are you thinking just a simple diff with an expected output?

Yes, but I think worth merging this first to un-break the templating, and I can open a new issue for better tests.

@dstansby dstansby merged commit b2eff42 into main Mar 25, 2024
15 checks passed
@dstansby dstansby deleted the revert-309-fix-package-name branch March 25, 2024 10:38
@dstansby
Copy link
Member Author

Issue opened at #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants