Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CITATION.cff file #340

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Add CITATION.cff file #340

merged 3 commits into from
Apr 29, 2024

Conversation

matt-graham
Copy link
Collaborator

Part of #330

Adds a CITATION.cff file for this repository with all current contributors included as authors.
The ordering of authors should match the non-bot accounts on https://github.com/UCL-ARC/python-tooling/graphs/contributors

I have added ORCIDs for everyone I could find them for either from GitHub profile or ARC people directory. Similarly I have tried to enter given and family names as listed on GitHub Profile or ARC people directory but add a review comment if I've made any mistakes or you would prefer to be listed differently.

I am requesting a review from everyone who is listed as an author. If you are happy to be included as an author and don't want any changes made to your information please approve. If you need any changes made to your information or want to be removed as an author please add a review and request changes accordingly.

As I ran out of reviewer slots (maximum of 15 😅) I'm manually tagging @paddyroddy and @samcunliffe

@matt-graham
Copy link
Collaborator Author

@sfmig @adamltyson @alessandrofelder I've listed everyones' affiliation as UCL but let me know if you would prefer I change this to Sainsbury Wellcome Centre

CITATION.cff Outdated
@@ -0,0 +1,84 @@
cff-version: "1.2.0"
message: "If you use this template or the associated website, please cite it using these metadata."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment this asks people to use this citation for both template and website. In #330 we discussed possibly making website separately citeable so we may want to change this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫐

@alessandrofelder
Copy link
Contributor

@sfmig @adamltyson @alessandrofelder I've listed everyones' affiliation as UCL but let me know if you would prefer I change this to Sainsbury Wellcome Centre

Given we also don't specify ARC/Mech Eng/... the UCL affiliation seems reasonable to me.

@p-j-smith
Copy link
Contributor

As I ran out of reviewer slots (maximum of 15 😅) I'm manually tagging @paddyroddy and @samcunliffe

Perhaps we should make a python-tooling Team?

@paddyroddy
Copy link
Member

paddyroddy commented Apr 12, 2024

Perhaps we should make a python-tooling Team?

Nice idea, but in this case @matt-graham wants everyone to review it. As soon as one of the team reviewed, the team wouldn't be visible any more.

@p-j-smith
Copy link
Contributor

Nice idea, but in this case @matt-graham wants everyone to review it. As soon as one of the team reviewed, the team wouldn't be visible any more.

Ah yeah, that's a good point. But at least everyone would be notified that they've been requested to review

@paddyroddy
Copy link
Member

@robertvi @mxochicale @yidilozdemir could you have a look? When @dpshelio gets back, we should be good to go - I'll prod him in person if he hasn't done it

Copy link
Member

@mxochicale mxochicale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matt and all.

This looks good to me.

Perhaps for next iterations:

  • try to add some version release and associated doi. From this reference:
version: 2.0.4
doi: 10.5281/zenodo.1234
date-released: 2017-12-18
  • Some family-names and give names have quotes. Not sure how this affects the creation of the citation but I guess it should be some kind of consistency.

Thanks, Miguel

@matt-graham
Copy link
Collaborator Author

matt-graham commented Apr 19, 2024

Thanks for the comments @mxochicale

* try to add some version release and associated doi. From this [reference](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files):
version: 2.0.4
doi: 10.5281/zenodo.1234
date-released: 2017-12-18

We have the Zenodo GitHub integration set up already so can add a DOI once we have made a release and a DOI has been minted. In terms of including a version - I would be reticent to have this included unless we had some automated workflow for ensuring this kept up to date with the latest release version as I suspect otherwise it will quickly end up going out of sync.

* Some family-names and give names have quotes. Not sure how this affects the creation of the citation but I guess it should be some kind of consistency.

I created the CFF file initially with cffinit tool (https://citation-file-format.github.io/cff-initializer-javascript/#/) - it looks like the quotes have been added to names with spaces or non-ASCII characters / characters with accents. We could potentially normalize everything to have quotation marks.

@paddyroddy
Copy link
Member

We have the Zenodo GitHub integration set up already so can add a DOI once we have made a release and a DOI has been minted. In terms of including a version - I would be reticent to have this included unless we had some automated workflow for ensuring this kept up to date with the latest release version as I suspect otherwise it will quickly end up going out of sync.

When it comes to the Zenodo release, you get a generic DOI (that refers to the whole record) and one for each new version. IMO it's much easier to stick with the generic one, and then you don't need to change anything.

@matt-graham
Copy link
Collaborator Author

When it comes to the Zenodo release, you get a generic DOI (that refers to the whole record) and one for each new version. IMO it's much easier to stick with the generic one, and then you don't need to change anything.

Yeah I also usually use the non-version-specific DOI - I was referring above to the suggestion to include a version (and release date) in the CITATION.cff itself which is possible but then requires us to keep this up to date with the latest release (and if we're using the non-version specific DOI probably doesn't make sense anyway).

@matt-graham matt-graham merged commit 3d34928 into main Apr 29, 2024
15 checks passed
@matt-graham matt-graham deleted the mmg/add-citation-cff branch April 29, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.