Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prettier linting error in CITATION.cff #366

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

matt-graham
Copy link
Collaborator

Not sure how it slipped through

@matt-graham matt-graham requested a review from paddyroddy April 29, 2024 13:03
@samcunliffe samcunliffe merged commit 91b8c3e into main Apr 29, 2024
15 checks passed
@samcunliffe samcunliffe deleted the mmg/citation-linting-fix branch April 29, 2024 13:21
@paddyroddy
Copy link
Member

paddyroddy commented Apr 29, 2024

Not sure how it slipped through

It's due to this PR #364

@matt-graham
Copy link
Collaborator Author

Did you mean to link to #356?

What confused me if so is that I think after that PR was merged in to main you then merged main in to the PR branch for #340 (eac56e4) for which the linting check failed on the CITATION.cff file and then subsequently fixed this linting error in 7d89757, which appears to be introducing the additional new line which prettier then subsequently complained about when running the linting on the merge of #340 to main?

@paddyroddy
Copy link
Member

Did you mean to link to #356?

Sorry, that was meant to be #364. It turns out proseWrap: true formats differently to proseWrap: false. So after #364 was merged, main should have been merged in - which would have then failed linting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants