Skip to content

Commit

Permalink
[frontend/user_manager] language not in DB by default
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexandreDoneux committed Feb 27, 2024
1 parent 3fc8f03 commit e799111
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
3 changes: 1 addition & 2 deletions inginious/frontend/installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -567,8 +567,7 @@ def configure_authentication(self, database):
"realname": realname,
"email": email,
"password": UserManager.hash_password(password),
"bindings": {},
"language": "en"})
"bindings": {}})

options["superadmins"].append(username)

Expand Down
2 changes: 1 addition & 1 deletion inginious/frontend/pages/preferences/profile.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def save_profile(self, userdata, data):
return_document=ReturnDocument.AFTER)

# Check if updating language
if data["language"] != userdata["language"]:
if data["language"] != userdata.get("language", "en"):
language = data["language"] if data["language"] in self.app.available_languages else "en"
result = self.database.users.find_one_and_update({"username": self.user_manager.session_username()},
{"$set": {"language": language}},
Expand Down
6 changes: 2 additions & 4 deletions inginious/frontend/user_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -368,10 +368,9 @@ def connect_user(self, user):
- realname
- email
- username
- language => to be removed with removal from DB
"""

if not all(key in user for key in ["realname", "email", "username", "language"]):
if not all(key in user for key in ["realname", "email", "username"]):
raise AuthInvalidInputException()

ip = flask.request.remote_addr
Expand Down Expand Up @@ -597,8 +596,7 @@ def create_user(self, values):
"realname": values["realname"],
"email": values["email"],
"password": self.hash_password(values["password"]),
"bindings": {},
"language": "en"})
"bindings": {}})
return None

##############################################
Expand Down

0 comments on commit e799111

Please sign in to comment.