From c581ac6ce3069f0dc2a0e76d9125b88feee86bf0 Mon Sep 17 00:00:00 2001 From: thremilien Date: Tue, 20 Aug 2024 13:33:37 +0000 Subject: [PATCH 1/2] id check --- inginious/frontend/course_factory.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/inginious/frontend/course_factory.py b/inginious/frontend/course_factory.py index 05e66d329..9102a310a 100644 --- a/inginious/frontend/course_factory.py +++ b/inginious/frontend/course_factory.py @@ -8,7 +8,7 @@ from pymongo import ReturnDocument from inginious.frontend.log import get_course_logger - +from inginious.common.base import id_checker from inginious.frontend.exceptions import CourseNotFoundException, CourseAlreadyExistsException, TasksetNotFoundException from inginious.frontend.courses import Course @@ -57,6 +57,9 @@ def import_legacy_course(self, database, courseid): return_document=ReturnDocument.AFTER) def create_course(self, courseid, descriptor): + if not id_checker(taskid): + raise InvalidNameException("Task with invalid name: " + taskid) + existing_course = self._database.courses.find_one({"_id": courseid}) if existing_course: raise CourseAlreadyExistsException() From b4b97f8acdf17e4d16ad0ba8c59bba7a521309c5 Mon Sep 17 00:00:00 2001 From: thremilien Date: Tue, 20 Aug 2024 14:41:08 +0000 Subject: [PATCH 2/2] typo --- inginious/frontend/course_factory.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/inginious/frontend/course_factory.py b/inginious/frontend/course_factory.py index 9102a310a..07673d900 100644 --- a/inginious/frontend/course_factory.py +++ b/inginious/frontend/course_factory.py @@ -57,8 +57,8 @@ def import_legacy_course(self, database, courseid): return_document=ReturnDocument.AFTER) def create_course(self, courseid, descriptor): - if not id_checker(taskid): - raise InvalidNameException("Task with invalid name: " + taskid) + if not id_checker(courseid): + raise InvalidNameException("Course with invalid name: " + courseid) existing_course = self._database.courses.find_one({"_id": courseid}) if existing_course: