Merge pull request #1288 from UN-OCHA/aessid/HPC-10017

HPC-10017: Visual bug in related article element that don't have images.

Author: berliner

html/modules/custom/ghi_blocks/src/Plugin/Block/Generic/Links.php

@@ -62,9 +62,15 @@ public function buildContent() {
       $item_type = $this->getItemTypePluginForColumn($item, $context);
       $rendered[] = $item_type->getRenderArray();
     }
+
+    $rendered = array_filter($rendered);
+    if (empty($rendered)) {
+      return NULL;
+    }
+
     $build = [
       '#theme' => 'item_list',
-      '#items' => array_filter($rendered),
+      '#items' => $rendered,
       '#attributes' => [
         'class' => ['links'],
       ],

html/modules/custom/ghi_blocks/src/Plugin/ConfigurationContainerItem/Link.php

@@ -304,7 +304,7 @@ public function getRenderArray() {
       '#link' => $link->toRenderable(),
     ];
     $file = $this->loadFile();
-    if ($file) {
+    if ($file && file_exists($file->getFileUri())) {
       $image_style = 'card_hero';
       if ($this->config['image']['crop_type'] == 'paper_size') {
         $image_style = 'paper_size';
@@ -432,4 +432,15 @@ private function loadFile($file_id = NULL) {
     return $file_id ? $this->entityTypeManager->getStorage('file')->load($file_id) : NULL;
   }
 
+  /**
+   * {@inheritdoc}
+   */
+  public function getConfigurationErrors() {
+    $errors = [];
+    if (!$this->getRenderArray()) {
+      $errors[] = $this->t('The link cannot be rendered. Verify that the target page is publicly available.');
+    }
+    return $errors;
+  }
+
 }

html/themes/custom/common_design_subtheme/css/styles.css

@@ -15,5 +15,14 @@
     /* The 2.25rem are for the padding of the text */
     width: calc(40% - 2.25rem);
     min-width: 320px;
+
+    [dir="ltr"] .gho-related-article .field--name-field-image {
+      padding-right: 2.25rem;
+      padding-left: 0;
+    }
+    [dir="rtl"] .gho-related-article .field--name-field-image {
+      padding-right: 0;
+      padding-left: 2.25rem;
+    }
   }
 }

html/themes/custom/common_design_subtheme/sass/component-overrides/_gho-related-articles.scss

@@ -7,7 +7,6 @@
 }
 
 div.link-box {
-  gap: 1rem;
   padding: 0 !important;
   border: 1px solid var(--ghi-default-border-color) !important;