Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPS-10828] Enable access to Entra ID login and registration forms #960

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[OPS-10828] Enable access to Entra ID login and registration forms #960

wants to merge 4 commits into from

Conversation

orakili
Copy link
Collaborator

@orakili orakili commented Dec 5, 2024

Refs: OPS-10828, OPS-10896

This adds the permissions to access to Entra ID login and registration forms after we receive the approval (see OPS-10896).

@orakili orakili added the blocked This PR is blocked, do not merge it label Dec 5, 2024
@orakili orakili mentioned this pull request Dec 5, 2024
Merged
@orakili orakili requested a review from cafuego December 5, 2024 02:23
@orakili orakili changed the title chore: enable access to Entra ID login and registration forms [OPS-10828] Enable access to Entra ID login and registration forms Dec 5, 2024
cafuego
cafuego previously approved these changes Dec 5, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions Docker version 26.1.3, build b72abbb PHP 8.3.15 (cli) (built: Dec 19 2024 07:25:41) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.15, Copyright (c) Zend Technologies with Zend OPcache v8.3.15, Copyright (c), by Zend Technologies with Xdebug v3.4.0, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.8.4 2024-12-11 11:57:47
Drupal Logs
PHP Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

@orakili orakili changed the base branch from feature/OPS-10828-entraid to develop December 5, 2024 04:49
@orakili orakili dismissed cafuego’s stale review December 5, 2024 04:49

The base branch was changed.

@orakili orakili requested a review from cafuego December 5, 2024 04:50
@orakili
Copy link
Collaborator Author

orakili commented Dec 5, 2024

Sorry, no code change, just different target branch.

@orakili orakili mentioned this pull request Dec 5, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Coverage Report

Totals Coverage
Statements: 18.41% ( 2307 / 12530 )
Methods: 19.03% ( 137 / 720 )
Lines: 18.37% ( 2170 / 11810 )

cafuego
cafuego approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@cafuego cafuego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still approved tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafuego cafuego cafuego approved these changes

Assignees
No one assigned
Labels
blocked This PR is blocked, do not merge it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orakili @cafuego