Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check pimCmdRedSum template behavior #8

Open
deyuan opened this issue Jul 23, 2024 · 0 comments
Open

Double check pimCmdRedSum template behavior #8

deyuan opened this issue Jul 23, 2024 · 0 comments
Assignees

Comments

@deyuan
Copy link
Collaborator

deyuan commented Jul 23, 2024

Need to double check below behavior:

In pimCmdRedSum class, the computeRegion is a virtual function:

virtual bool computeRegion(unsigned index) override;

In pimCmd.cpp file, this function takes a template data type:

template <typename T> bool
pimCmdRedSum<T>::computeRegion(unsigned index)

The pimCmd::computeAllRegions function does not pass any template data type to the virtual computeRegion function.

@fasiddique fasiddique self-assigned this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants