close jetty connections on monix timeout (or other cancellation) #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddworak
reviewed
Dec 13, 2024
rest/jetty/src/test/scala/io/udash/rest/jetty/CloseStaleJettyConnectionsOnMonixTimeout.scala
Outdated
Show resolved
Hide resolved
rest/jetty/src/test/scala/io/udash/rest/jetty/CloseStaleJettyConnectionsOnMonixTimeout.scala
Outdated
Show resolved
Hide resolved
rest/jetty/src/test/scala/io/udash/rest/jetty/CloseStaleJettyConnectionsOnMonixTimeout.scala
Outdated
Show resolved
Hide resolved
halotukozak
force-pushed
the
close-stale-jetty-connections-on-monix-timeout
branch
from
5830008 to
a161834
Compare
ddworak
requested changes
Dec 18, 2024
halotukozak
force-pushed
the
close-stale-jetty-connections-on-monix-timeout
branch
from
cb56a4d to
b00c43b
Compare
Updated test syntax to use `in` for better readability and migrated to fully asynchronous assertions where applicable. Removed redundant `.futureValue` statements, ensuring non-blocking behavior across test methods.
halotukozak
force-pushed
the
close-stale-jetty-connections-on-monix-timeout
branch
from
9a35f65 to
01cf9f0
Compare
Clarify the purpose of HttpClient configurations in `SttpRestCallTest` and `JettyRestCallTest`. The added comments explain the use of a connection timeout significantly exceeding the CallTimeout value, improving code readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A config for jetty client can have idleTimeout property set to 2h (that means each client connection is closed after 2h if no communication is sent over the connection). This behavior may don't match e.g. 60 seconds monix task timeout setting. Long running http requests inside monix task causes the task to cancel without closing underlying jetty client connection session. Jetty client connection pool is then used up and accepts no more requests effectively blocking the communication.