feat(sdk): add job-attachments ease-of-use method #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexenica
force-pushed
the
feature/add_attachmetns_easeofuse
branch
from
951ab80 to
ba9e553
Compare
alexenica
force-pushed
the
feature/add_attachmetns_easeofuse
branch
10 times, most recently
from
8b591d5 to
90069fa
Compare
alexenica
changed the title
alexenica
force-pushed
the
feature/add_attachmetns_easeofuse
branch
from
90069fa to
6d2e412
Compare
gheorghitahurmuz
force-pushed
the
feature/add_attachmetns_easeofuse
branch
from
6d2e412 to
edc1f77
Compare
alexenica
force-pushed
the
feature/add_attachmetns_easeofuse
branch
from
edc1f77 to
94314bf
Compare
alexenica
force-pushed
the
feature/add_attachmetns_easeofuse
branch
from
9ffb4f9 to
74425e0
Compare
gheorghitahurmuz
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new methods in the jobs_attachment_service, providing ease of use for attaching stuff to the current running job. The underlying idea is to use provided jobKey to upload and link an attachemnt to, if that is not present use context jobKey, if that is not preset just write to local storage.